Make neural-assisted prediction the default - #972
Merged
Merged
Conversation
The setup guide is revealed in the same render that removes the pairing dialog, so wait for both in one assertion with a longer timeout instead of a separate default one-second wait that could expire on slow CI. Closes #947 Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
The flake came from the auto-open markSetupShown response, which still carried the pending pairing, landing after the cancellation event and restoring the pairing dialog. Wait for that response first and keep the fallback state consistent with the cancellation event. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
enaboapps
marked this pull request as ready for review
October 4, 2026 10:40
enaboapps
marked this pull request as draft
October 4, 2026 10:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Word prediction returns statistical suggestions immediately and refines them asynchronously with the offline SmolLM2 companion whenever prediction is enabled. Existing disabled preferences remain disabled. Suggestions stay selectable and unchanged while their row is scanned; acceptance validates the displayed batch token rather than reinterpreting an old index.
Bundles the verified Q8 model, tokenizer, notices and platform workers. Windows selects AVX2 only on compatible CPUs. The parent libraries pin merged switchifyapp/switchify-prediction#22 at 171210ee89e3944d1c606d50ad779a5dfb1651b8; released v0.2.0 worker/model identities remain unchanged and protocol-compatible. Neural reply timeouts are 2 seconds, increased from 500 ms at the user's request after macOS qualification failures. Startup remains bounded at 30 seconds, and failures preserve statistical results until explicit retry or keyboard reopening.
Validation on reviewed head 06b3e78:
Machine-readable reports are in the prediction-benchmark-Windows and prediction-benchmark-macOS artifacts of the passing CI run. The updated local Windows run also completed 1,000 refinements without failures, with immediate p95 9.21 ms and refinement p95 90.96 ms. Reproduction and historical measurements are documented in docs/neural-prediction.md.
Measurements use synthetic context, fake activity/input and real neural child IPC with 20 ms polling. They exclude outer desktop IPC and rendering. The benchmark allows at most five simulated explicit keyboard sessions, reports every failed attempt, and still requires 1,000 successful warmed refinements. Neither final platform needed a restart. Earlier 500 ms macOS failures remain recorded in the documentation and prior CI artifacts. Known model-quality regressions remain; passing latency checks does not establish unseen-data accuracy. Signed installation and manual macOS Accessibility testing remain release checks not claimed here.
Includes the existing test-only fixes from PR #970 because the unchanged pairing test failed initial frontend CI. Its original branch was left untouched. No RC version bump or release is included.
Closes #971.