Repository navigation
Conversation
The setup guide is revealed in the same render that removes the pairing dialog, so wait for both in one assertion with a longer timeout instead of a separate default one-second wait that could expire on slow CI. Closes #947 Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
The flake came from the auto-open markSetupShown response, which still carried the pending pairing, landing after the cancellation event and restoring the pairing dialog. Wait for that response first and keep the fallback state consistent with the cancellation event. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Contributor
Author
|
Closing as already incorporated through #972 and shipped in v1.0.0-rc.20. Independent review confirmed that src/App.test.tsx is byte-for-byte identical at this PR head (6b3c0d8), the #972 merge (30e8322), and current main (5d18548), with Git blob 56152c8a146aa88721eb1037d3ad2d880461118f. The targeted cancellation test also passed on current main with Node 24.13.0. No additional merge or code changes are needed; #947 is already closed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #947.
The UI test "clears a cancelled pairing request from the setup guide runtime event" failed once in CI (run 36432010744) with
Unable to find role="dialog" and name "Input access"after its one-second wait.Cause
When the setup guide auto-opens,
openSetup()callsperform(api.markSetupShown). In the browser fallback that returns a copy ofbrowserState, which the test never updated, so it still held the pending pairing. If that response settled after the test's cancellation event,syncStaterestored the pairing, the pairing dialog reappeared and the setup guide was hidden again for the rest of the wait. A longer timeout alone does not fix this.Change
markSetupShownresponse to settle before emitting the cancellation.browserStateitself for the cancellation so any later fallback response matches the event.Validation at 6b3c0d8
🤖 Generated with Claude Code