Repository navigation
Restyle tabs and option groups - #895
Merged
Merged
Conversation
enaboapps
force-pushed
the
884-home-status
branch
from
September 25, 2026 10:56
2167160 to
e9247b4
Compare
enaboapps
force-pushed
the
885-tabs-options
branch
2 times, most recently
from
September 25, 2026 11:03
338f293 to
054f9e2
Compare
enaboapps
marked this pull request as ready for review
September 25, 2026 11:49
Tabs become one underlined row that shares the width and scrolls sideways only when it cannot fit, so Settings no longer wraps its last tab onto a line of its own. The selected tab is marked by a brand underline and heavier text, with a Highlight border under forced colours, and focus draws an inset ring the scrolling row cannot clip. Selected choices in option groups and setup choices fill with the brand container and carry a drawn tick that stays out of the accessible name. Closes #885 Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Between roughly 800px and 890px the Settings tabs overflowed the scrolling row and hid Updates, its failure marker and, after opening Updates from the banner, the selected tab itself. Tabs now split the row equally and wrap long labels inside themselves; the row wraps only when single words cannot fit. Tabs keep one weight so changing tab never shifts neighbours, and unselected choices get their hover back. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
A tab's 64px minimum overrode its word width, so at high zoom a long word spilled out of its tab instead of the row wrapping. Tabs now never shrink below their longest word. The restored hover no longer applies to disabled choices, which Chromium still hovers. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
enaboapps
force-pushed
the
884-home-status
branch
from
September 25, 2026 11:50
0f25257 to
fc784dd
Compare
enaboapps
force-pushed
the
885-tabs-options
branch
from
September 25, 2026 11:50
054f9e2 to
61f8f64
Compare
enaboapps
marked this pull request as draft
September 25, 2026 11:50
enaboapps
marked this pull request as ready for review
September 25, 2026 13:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #885. Stacked on #894, tracked in #891.
What changed
Validation
On this head:
npm run lintpassednpm testpassed: 238 Vitest tests and 5 Node testsnpm run buildpassedcargo fmt --check,cargo clippy --all-targets -D warningsandcargo testpassed (566 tests, 1 ignored). No Rust changes in this stack.Review follow-up
An independent review of this layer's head raised these points, now addressed:
🤖 Generated with Claude Code
Rebase validation (2026-09-25)
Rebased onto current
main(7fb8fce, including #881) in stack order.git range-diffshows every commit in this PR is patch-equivalent to its previous head, and the intended parent remains its PR base. On the final stack tip (40c75cc), Node 24.19.0 lint, tests and build passed; Rust 1.97.1 format check, Clippy and tests passed. An independent review of the updated PR heads found no actionable findings. CI is rerunning on each new head.