Repository navigation
Consolidate main-window styles into one design system - #892
Merged
Merged
Conversation
Merge the legacy compact stylesheet and the large-target overrides into a single component layer with named tokens. Move Button, Input and Select sizing from Tailwind utilities into .btn and .field-control so variants can actually differ: primary, secondary, text, icon and danger now each have their own weight, and disabled controls go neutral instead of fading the brand red to pink. Closes #882 Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
A disabled fieldset already dims its whole group, so fields inside it keep their normal colours rather than also turning grey, matching how buttons are treated. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
enaboapps
force-pushed
the
882-design-system
branch
from
September 25, 2026 11:50
0758355 to
873aebb
Compare
enaboapps
marked this pull request as draft
September 25, 2026 11:50
enaboapps
marked this pull request as ready for review
September 25, 2026 13:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #882. First layer of the stack tracked in #891.
What changed
src/styles.cssnow only declares layers and imports. The legacy compact stylesheet and the large-target overrides are merged into onecomponentslayer insrc/ui/app.css, ordered tokens, base, controls, page areas, responsive.Button,InputandSelectno longer carry Tailwind size utilities, which outranked every variant. Their shape lives in.btnand.field-control, so variants can differ.Layout is otherwise unchanged. Later layers restyle rows, Home, tabs, forms, Switches, Mobile and dialogs.
Validation
Node 24.13.0, Rust 1.97.1, on this head:
npm run lintpassednpm testpassed: 224 Vitest tests and 5 Node testsnpm run buildpassedcargo fmt --check,cargo clippy --all-targets -D warningspassedcargo testpassed: 566 tests, 1 ignoredmain.Review follow-up
An independent review of this layer's head raised these points, now addressed:
mainare intentional. Profile rows now lay out as a grid instead of a centred row, and Scanning mode card content is left-aligned. Both came from Tailwind utilities that used to outrank the old rules.🤖 Generated with Claude Code
Rebase validation (2026-09-25)
Rebased onto current
main(7fb8fce, including #881) in stack order.git range-diffshows every commit in this PR is patch-equivalent to its previous head, and the intended parent remains its PR base. On the final stack tip (40c75cc), Node 24.19.0 lint, tests and build passed; Rust 1.97.1 format check, Clippy and tests passed. An independent review of the updated PR heads found no actionable findings. CI is rerunning on each new head.