Repository navigation
Unify list rows, page headers and the sidebar - #893
Merged
Merged
Conversation
This was referenced Sep 25, 2026
enaboapps
force-pushed
the
883-rows-headers-sidebar
branch
from
September 25, 2026 10:56
29dd84b to
b9c822c
Compare
enaboapps
marked this pull request as ready for review
September 25, 2026 11:49
Status, task, device and profile lists share one grouped-row card: icon, text and trailing actions, dropping actions under the text only when the list is narrow. Every row subject gets the same icon tile. Page headers put the subtitle under the title and drop decorative corner icons, and the nested Mobile sub-views use section headers instead of a second h1. The sidebar marks the active page with a raised surface and brand bar and exposes it with aria-current. Closes #883 Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
The forced-colours outline marking the current page replaced the focus ring on that same button. Focus now draws its own CanvasText ring there. The Mobile sub-views become plain containers so screen readers do not announce each tab's name twice as a region, and the empty paired-devices heading drops to h3 beneath its section heading. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
enaboapps
force-pushed
the
882-design-system
branch
from
September 25, 2026 11:50
0758355 to
873aebb
Compare
enaboapps
force-pushed
the
883-rows-headers-sidebar
branch
from
September 25, 2026 11:50
b9c822c to
ff5c0f1
Compare
enaboapps
marked this pull request as draft
September 25, 2026 11:50
enaboapps
marked this pull request as ready for review
September 25, 2026 13:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #883. Stacked on #892, tracked in #891.
What changed
h1inside Mobile. They are now sections with anh2header. The profile editor's focus fallback follows the new header class.aria-current="page"and shows a Highlight outline under forced colours.Validation
On this head:
npm run lintpassednpm testpassed: 224 Vitest tests and 5 Node testsnpm run buildpassedcargo fmt --check,cargo clippy --all-targets -D warningsandcargo testpassed (566 tests, 1 ignored). No Rust changes in this stack.Review follow-up
An independent review of this layer's head raised these points, now addressed:
h3.🤖 Generated with Claude Code
Rebase validation (2026-09-25)
Rebased onto current
main(7fb8fce, including #881) in stack order.git range-diffshows every commit in this PR is patch-equivalent to its previous head, and the intended parent remains its PR base. On the final stack tip (40c75cc), Node 24.19.0 lint, tests and build passed; Rust 1.97.1 format check, Clippy and tests passed. An independent review of the updated PR heads found no actionable findings. CI is rerunning on each new head.