Repository navigation
Handle spacing and capitals for scanned punctuation - #873
Merged
Merged
Conversation
enaboapps
marked this pull request as ready for review
September 24, 2026 14:20
enaboapps
marked this pull request as draft
September 24, 2026 14:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #872.
Change
. , ! ? : ;as prose punctuation. It removes a preceding space only when the keyboard's own insertion is still verified, then inserts one space after the mark. The Numbers-page period remains literal for decimals.Validation
npm run lint— passnpm test— pass (223 UI tests, 5 update-feed tests)npm run build— passcargo fmt --manifest-path src-tauri/Cargo.toml --check— passcargo clippy --manifest-path src-tauri/Cargo.toml --all-targets -- -D warnings— passcargo test --manifest-path src-tauri/Cargo.toml— pass (538 Rust unit tests, 7 integration tests; 1 ignored)ce32bdfwith Node 24.19.0 and the ARM64 Windows Tauri debug target. With Notepad foreground, assigned switch-key events sent through Windows SendKeys opened the scanned keyboard and selected Space, period, a, comma, Space, b, the Numbers page, 1, decimal point, and 6. The resulting text matched. A, b1.6: the owned space was removed before the period, one was inserted after punctuation, the next letter was capitalized, the extra Space was suppressed, and the Numbers-page period stayed literal. The keyboard overlay remained visible without taking focus. Original VM switch and scanning settings were restored after the test.a3aefcdand used assigned switch-key events in Notepad to enter a space, period, and letter. The overlay showed active “Shift / Next key” with uppercase letters after the period, then Shift inactive after the letter; resulting text matched. A. Both VM settings files were restored byte for byte after testing, and Switchify was restarted with those originals.a3aefcd: no remaining actionable findings.