Skip to content

Dock scanning panels in any of nine screen positions - #875

Merged
enaboapps merged 4 commits into
mainfrom
panel-dock-positions
Sep 24, 2026
Merged

enaboapps merged 4 commits into
mainfrom
panel-dock-positions

Conversation

@enaboapps

@enaboapps enaboapps commented Sep 24, 2026 •

Copy link
Copy Markdown
Contributor

Closes #874

Summary

  • scan_panel gains a reusable Dock (column × row, each start/middle/end) that places the panel background in any of nine screen positions, plus shared position_rows / position_label helpers for a Position page.
  • The keyboard and mouse panels replace their Dock top / Dock bottom toggle with a Position key that opens a 3×3 grid (Top left … Bottom right) and a Back key. The current position is marked with • and active styling. Choosing a position docks the panel there and returns to the page the user came from.
  • point_workflow::Workflow owns one dock shared by both panels, so moving the mouse panel also moves the keyboard, and the position survives panels being rebuilt (reset, mode switches, config restart). It is not persisted across app restarts; no storage or protocol schema changes.
  • Word predictions are hidden while the keyboard shows the Position page (new suggestion batches do not reset its scan) and return with Back.

Review

Independent agent reviews of 09659ea, f7f411e, and the integrated latest head 849f955 found nothing actionable. Follow-ups noted: the dock resets to Bottom when scanning restarts (not persisted, as before), and the Top right dock may sit under the Windows modifier chip overlay while modifiers are held.

Validation

  • cargo fmt --check, cargo clippy --all-targets -D warnings: clean
  • cargo test after merging current main: 542 passed (new: every-dock geometry, keyboard/mouse Position page, dock shared both ways between keyboard and mouse in workflow; keyboard work-area fit test now covers all nine docks × five scales × three pages)
  • npm run lint, npm test (223 passed), npm run build: pass after merging current main
  • PR head 849f955 resolves the overlap with Handle spacing and capitals for scanned punctuation #873 while preserving both the Position page and smart punctuation/automatic Shift behavior.

🤖 Generated with Claude Code

Replace the keyboard and mouse Dock top/bottom toggle with a shared
Position page offering a 3×3 grid of screen positions. The chosen
position is shared by both panels and kept when they are rebuilt.

Closes #874

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@enaboapps enaboapps added this to the v1.0.0-rc.16 milestone Sep 24, 2026
Suggestion batches no longer reset the scan while the keyboard shows
the Position page, and the workflow test now covers a keyboard dock
change reaching the mouse panel.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@enaboapps
enaboapps marked this pull request as ready for review September 24, 2026 15:17
@enaboapps
enaboapps merged commit 3ddb5f3 into main Sep 24, 2026
6 checks passed
@enaboapps
enaboapps deleted the panel-dock-positions branch September 24, 2026 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dock scanning panels in any of nine screen positions

2 participants