Repository navigation
Dock scanning panels in any of nine screen positions - #875
Merged
Merged
Conversation
Replace the keyboard and mouse Dock top/bottom toggle with a shared Position page offering a 3×3 grid of screen positions. The chosen position is shared by both panels and kept when they are rebuilt. Closes #874 Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Suggestion batches no longer reset the scan while the keyboard shows the Position page, and the workflow test now covers a keyboard dock change reaching the mouse panel. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
enaboapps
marked this pull request as ready for review
September 24, 2026 15:17
added 2 commits
September 24, 2026 16:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #874
Summary
scan_panelgains a reusableDock(column × row, each start/middle/end) that places the panel background in any of nine screen positions, plus sharedposition_rows/position_labelhelpers for a Position page.•and active styling. Choosing a position docks the panel there and returns to the page the user came from.point_workflow::Workflowowns one dock shared by both panels, so moving the mouse panel also moves the keyboard, and the position survives panels being rebuilt (reset, mode switches, config restart). It is not persisted across app restarts; no storage or protocol schema changes.Review
Independent agent reviews of 09659ea, f7f411e, and the integrated latest head 849f955 found nothing actionable. Follow-ups noted: the dock resets to Bottom when scanning restarts (not persisted, as before), and the Top right dock may sit under the Windows modifier chip overlay while modifiers are held.
Validation
cargo fmt --check,cargo clippy --all-targets -D warnings: cleancargo testafter merging currentmain: 542 passed (new: every-dock geometry, keyboard/mouse Position page, dock shared both ways between keyboard and mouse in workflow; keyboard work-area fit test now covers all nine docks × five scales × three pages)npm run lint,npm test(223 passed),npm run build: pass after merging currentmain849f955resolves the overlap with Handle spacing and capitals for scanned punctuation #873 while preserving both the Position page and smart punctuation/automatic Shift behavior.🤖 Generated with Claude Code