Omit redundant Dex flow type headers - #2
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FlowTypeProvidernoneRationale
Step and RPC activity inputs already contain their flow type. Persisting the same value in
__temporal_sdk_dex_flow_typeadds redundant bytes to every scheduled activity event.User impact
New histories omit the private header for activities with a flow type provider. Existing histories and activities without a provider remain compatible. Metric names and non-empty labels are unchanged.
Validation
go run . checkgo run . unit-test -run 'TestDex'go test -count 1 -race ./replaytests -run 'TestReplayTestSuite/TestReplayLegacyActivityHeaderWithDexFlowTypeProvider'SERVICE_ADDR=127.0.0.1:7233 SERVICE_HTTP_ADDR=127.0.0.1:7243 go run . integration-test -run 'TestIntegrationSuite/TestDex'SERVICE_ADDR=127.0.0.1:7233 SERVICE_HTTP_ADDR=127.0.0.1:7243 WORKFLOW_CACHE_SIZE=0 go run . integration-test -run 'TestIntegrationSuite/TestDex'