Upgrade Temporal SDK flow header handling - #504
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
v1.47.1-superdurable.3FlowTypeProviderUpstream SDK change: superdurable/temporal-sdk-go#2
Published release: https://github.com/superdurable/temporal-sdk-go/releases/tag/v1.47.1-superdurable.3
Why
Step and RPC activity inputs already contain the Flow type. Persisting the same value in
__temporal_sdk_dex_flow_typeduplicates data in Temporal history. The new SDK treats a registeredFlowTypeProvideras authoritative while preserving legacy header consumption and inheritance for activities without that provider.Validation
make -C server unitTestsmake -C server temporalIntegTests integrationCoverageArgs="-run=^TestTemporalMetrics -temporalHostPort=127.0.0.1:7234"against an isolated Temporal dev serverGOWORK=off go mod tidy -diffforserver,server/cmd/server,cli, andprotos/codec-servermake -C sdk-go docsCheckGOWORK=off go test ./...inprotos/codec-serverWORKFLOW_CACHE_SIZE=0