Customize SDK metrics for Dex - #1
Merged
Merged
Conversation
longquanzheng
marked this pull request as ready for review
August 20, 2026 21:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rationale and user impact
Dex needs workflow and activity metrics labeled by runtime flow, step, subflow, and RPC types without coupling this SDK fork to Dex protobuf schemas. Providers keep schema knowledge in Dex while the SDK owns decoding reuse, propagation, failure handling, and metric naming. Existing
temporal_*dashboards and alerts must migrate to the documenteddex_*metric names.Validation
go run . checkgo run . unit-testgo run . integration-test -run 'TestIntegrationSuite/(TestDexMetricsProvidersAndNames|TestDexMetricsProviderPanicsSkipBusinessFunctions)'WORKFLOW_CACHE_SIZE=0 go run . integration-test -run 'TestIntegrationSuite/(TestDexMetricsProvidersAndNames|TestDexMetricsProviderPanicsSkipBusinessFunctions)'go test ./internal/... -run TestDexgo test -run TestReplayTestSuite/TestReplayLegacyActivityHeaderWithDexFlowTypeProvider ./test/replaytests