Repository navigation
Use customized Temporal metrics - #334
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dex_*Prometheus familiestemporal_samplesprefix and add end-to-end Prometheus coveragegithub.com/superdurable/temporal-sdk-go v1.47.1-superdurable.1and move Go modules/CI to Go 1.26Rationale and user impact
Temporal's default worker metrics cannot describe Dex Flow and Step types. The forked SDK now accepts runtime providers at registration, propagates Flow type metadata to regular and local activities, and rewrites metric names without taking a Dex protobuf dependency. Existing dashboards and alerts must migrate from
temporal_*ortemporal_samples_temporal_*selectors to the documenteddex_*families.SDK implementation: superdurable/temporal-sdk-go#1
Validation
make -C server unitTestsmake -C server temporalIntegTestsGOWORK=off go test ./integ -run '^TestTemporalMetrics$' -timeout 10m -cadence=false -search=false -dependencyWaitSeconds=1GOWORK=off go test ./...incli/npm run checkindocs/make copyright-checkGOWORK=off go mod tidyinserver/andcli/