CI: format generic methods with stable Go - #1954
Open
mattjohnsonpint wants to merge 1 commit into
Open
Conversation
Go 1.26 cannot parse generic methods, even in files excluded by build constraints. Run the formatting check only with stable Go 1.27 while continuing to test oldstable.
ccoVeille
approved these changes
Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Run the formatting check only with the stable Go toolchain.
Changes
.ci.gofmt.shto the stable matrix entry.Motivation
PR #1937 adds generic methods supported by Go 1.27.
Go 1.26 cannot parse generic methods, including those in files excluded by build constraints, causing its formatting check to fail. The stable Go 1.27 toolchain can format the complete source tree.
Related issues
Required for #1937