CI: keep version coverage and checks reliable - #1941
Closed
mattjohnsonpint wants to merge 1 commit into
Closed
mattjohnsonpint wants to merge 1 commit into
mattjohnsonpint wants to merge 1 commit into
Conversation
As stable and oldstable advance to Go 1.27 and Go 1.26, retain explicit Go 1.25 coverage so every supported release remains tested. Run language-level formatting validation with the stable toolchain because Go 1.26 cannot parse generic methods, even in files excluded by build constraints. Several CI helpers could previously report success when their underlying commands, generation checks, or action-pin validation failed. Ensure those failures are propagated and newly generated files are detected so a green build means the checks actually completed successfully.
dolmen
requested changes
Sep 1, 2026
dolmen
left a comment
dolmen
left a comment
Collaborator
There was a problem hiding this comment.
Too many unrelated changes in a single commit.
Please split in multiple commits (or even multiple PRs as I don't think that changing the workflow is related to the changes in the scripts). Each commit must explain the intent of the change.
dolmen
reviewed
Sep 1, 2026
Comment on lines
+5
to
+6
| unformatted_files="$(gofmt -l .)" | ||
| if [ -n "$unformatted_files" ]; then |
Collaborator
There was a problem hiding this comment.
This change is an example of making the review harder than necessary:
- this is not a functional change: dropping that change would have no impact, but the reviewer has to check that
- as this is mixed with plenty of other changes, the reviewer has to check how those changes interact. If that single change was in a single commit that tells the intent, it would be clearer that the change is contained
- the refactor is just to clarify the action done by this test. But just adding a comment before the code (instead of changing the code) would have been easier to review as there would be no question about interaction with other changes
Contributor
Author
There was a problem hiding this comment.
Got it. I'll revise, simplify and split up as necessary for clarity.
mattjohnsonpint
marked this pull request as draft
September 1, 2026 14:52
Contributor
Author
|
Closing this PR. I'll create a few new ones. Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As stable and oldstable advance to Go 1.27 and Go 1.26, retain explicit Go 1.25 coverage so every supported release remains tested. Run language-level formatting validation with the stable toolchain because Go 1.26 cannot parse generic methods, even in files excluded by build constraints.
Several CI helpers could previously report success when their underlying commands, generation checks, or action-pin validation failed. Ensure those failures are propagated and newly generated files are detected so a green build means the checks actually completed successfully.