CI: propagate code generation failures - #1952
Open
mattjohnsonpint wants to merge 1 commit into
Open
Conversation
Without errexit, a failed go generate command can be followed by a clean git diff and a successful script exit. Evaluate GOMOD separately so a failed go env command is propagated too.
dolmen
approved these changes
Sep 2, 2026
ccoVeille
approved these changes
Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CI currently tests the value of
GOMODif it exists, but it doesn't ensure thatgo envsucceeds.Changes
Update
.ci.gogenerate.shsuch that ifgo env GOMODfails, the script fails immediately.Motivation
This is just fixing an edge case for a possible false positive in CI.