Repository navigation
Stop installing CEF helpers into the macOS build bundle - #1806
Merged
Merged
Conversation
Helpers launch from <osn>/Frameworks; the extra copy under ../../Contents/Frameworks was never shipped or read. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
summeroff
force-pushed
the
chore/drop-mac-contents-frameworks
branch
from
October 15, 2026 16:29
530e3ac to
5fc0cd2
Compare
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
Runtime dependencies remain installed, and reported browser-load probes passed without the removed copies on both macOS architectures.
0 open findings
What changed in this PR
Removes redundant macOS CEF copies from the build bundle while preserving the runtime installation in <osn>/Frameworks.
Changes:
- Removes installation of the CEF framework and four helper apps into
../../Contents/Frameworks. - Removes the comment claiming those copies were required for macOS tests.
| File | Description |
|---|---|
| obs-studio-server/CMakeLists.txt | Removes build-bundle CEF installation rules; runtime packaging remains unchanged. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the macOS install of the CEF framework and helper apps into
../../Contents/Frameworks(i.e.streamlabs-build.app/Contents/Frameworks).CEF children launch from
<osn>/Frameworks, which stays installed. The copy wasn't in the shipped tarball (onlydistribute/obs-studio-nodeis packaged), and nothing in the repo reads it. Its comment blamed missing files for macOS CEF child failures; the real cause is a main-bundle mismatch, fixed separately.Evidence: on #1805 the browser-source load test passed on macOS arm64 and x86_64 from a
shim.app/distributecopy that has noContents/Frameworks.Best merged after the main-bundle fix PR so the permanent browser-source test covers this on macOS CI.
🤖 Generated with Claude Code