Repository navigation
[VirtualCam] Fix Windows code path to return exception - #1804
Merged
Merged
Conversation
| // On macOS, we will wait for a response. Our situation is more complicated due to the vcam SystemExtension | ||
| // which will return errors that we need to display to the user. | ||
| std::vector<ipc::value> response = conn->call_synchronous_helper("NodeOBS_Service", "OBS_service_startVirtualCam", {}); | ||
| if (response.size() > 1) { |
Collaborator
There was a problem hiding this comment.
Should we throw if the response is empty?
Contributor
Author
There was a problem hiding this comment.
Very good callout. I thought about updating the code path to return OK when all goes well and also tidy up the frontend code to check for OK. Right now, it just wraps this code in a try/catch on FE side and displays a popup if its' returned an exception.
aleksandr-voitenko
approved these changes
Oct 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When virtual camera is started on Windows, ensure it cannot silently fail.
Motivation and Context
Updated
startVirtualCamcode path to share the same implementation as MacOS where any error is displayed to user. I actually can no longer repro the original issue instagingwhere QA reports they could not get windows vcam to work after I restarted Windows (making sure to unhook previously loaded virtual cam DLL from zoom/slack etc) and rebuilt with latest OSN. So adding support for the same code path MacOS had in-place to display an error and print it to Desktopapp.log.How Has This Been Tested?
I verified when I start Virtual WebCam it can be started/stopped/restarted.
Types of changes
Checklist: