Skip to content

[Virtual WebCam] Display vcam error on Windows - #6312

Merged
michelinewu merged 1 commit into
stagingfrom
rno/display-virtualcam-error
Oct 15, 2026
Merged

michelinewu merged 1 commit into
stagingfrom
rno/display-virtualcam-error

Conversation

@sandboxcoder

@sandboxcoder sandboxcoder commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

Description

Update Desktop-Windows to display an error message if virtual webcam cannot be connected.

Below is example of the error message:
image

Related PR:
streamlabs/obs-studio-node#1804

QA Instructions

  • Open Settings
  • Click "Virtual Webcam" tab
  • Click Start Virtual Webcam
  • You should be able to see "Streamlabs Virtual Web Camera" in Zoom/Slack/Discord/GoogleMeet etc

* In a related PR, OSN is being updated to return
any virtual webcamera issue. Update Desktop to
display the exception.
@sandboxcoder
sandboxcoder requested a balanced review from Copilot October 14, 2026 20:06
@sandboxcoder sandboxcoder added the needs QA requires QA testing on the branch before merging label Oct 14, 2026
@sandboxcoder sandboxcoder added the needs new osn version This code is waiting for the next osn version before it can be merged label Oct 14, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The focused message change preserves existing macOS behavior; the remaining feedback concerns only QA documentation.

1 open finding
What changed in this PR

Adds Windows-specific virtual webcam startup error messaging, complementing the linked native error-reporting change.

Changes:

  • Displays a generic startup error on Windows while preserving macOS permission guidance.
  • Adds the corresponding English translation.
File Description
app/​services/​virtual-webcam.ts Selects startup error messages by operating system.
app/​i18n/​en-US/​settings.json Adds the Windows error message translation.

🧠 Review effort: Balanced


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment on lines +119 to +120
[OS.Windows]: () => {
errorMessage = $t('Unable to start virtual camera.');

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I verified the popup displays locally when I sabotaged my local build before posting the PR. If required, I could provide QA with a sabotaged Desktop build if they wish to verify the unhappy path.

@sandboxcoder
sandboxcoder marked this pull request as ready for review October 14, 2026 20:13
@bundlemon

bundlemon Bot commented Oct 14, 2026

Copy link
Copy Markdown

BundleMon

Files added (4)
Status Path Size Limits
✅ renderer.(hash).js
+10.73MB -
✅ vendors~renderer.(hash).js
+4.65MB -
✅ updater.js
+115.29KB -
✅ guest-api.js
+40.23KB -

Total files change +15.53MB

Final result: ✅

View report in BundleMon website ➡️


Current branch size history

@sandboxcoder
sandboxcoder marked this pull request as draft October 14, 2026 21:08
@sandboxcoder sandboxcoder removed the needs QA requires QA testing on the branch before merging label Oct 14, 2026
@sandboxcoder
sandboxcoder marked this pull request as ready for review October 15, 2026 17:08
@michelinewu
michelinewu merged commit 3a312fd into staging Oct 15, 2026
11 of 16 checks passed
@michelinewu
michelinewu deleted the rno/display-virtualcam-error branch October 15, 2026 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs new osn version This code is waiting for the next osn version before it can be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants