Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion jsonpointer.py
Original file line number Diff line number Diff line change
Expand Up @@ -239,7 +239,10 @@ def get_part(cls, doc, part):
if not JsonPointer._RE_ARRAY_INDEX.fullmatch(str(part)):
raise JsonPointerException("'%s' is not a valid sequence index" % part)

return int(part)
try:
return int(part)
except ValueError as e:
raise JsonPointerException("Invalid sequence index: %s" % (e,))

elif hasattr(doc, '__getitem__'):
# Allow indexing via ducktyping
Expand Down
42 changes: 42 additions & 0 deletions tests.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

import copy
import doctest
import sys
import unittest

import jsonpointer
Expand Down Expand Up @@ -252,6 +253,47 @@ def test_string_not_indexable(self):
self.assertRaises(JsonPointerException, ptr.resolve, doc)


@unittest.skipUnless(hasattr(sys, 'get_int_max_str_digits'),
'Integer string conversion limits are not available')
class LargeIndexTests(unittest.TestCase):

def setUp(self):
limit = sys.get_int_max_str_digits()
if not limit:
self.skipTest('Integer string conversion limit is disabled')
self.token = '1' * (limit + 1)
self.pointer = '/' + self.token

def test_resolve_large_index(self):
self.assertRaises(JsonPointerException, resolve_pointer,
[0], self.pointer)

def test_resolve_large_index_default(self):
default = object()
self.assertIs(resolve_pointer([0], self.pointer, default), default)
self.assertIs(resolve_pointer({'items': [0]},
'/items' + self.pointer, default),
default)

def test_to_last_large_index(self):
self.assertRaises(JsonPointerException,
JsonPointer(self.pointer).to_last, [0])

def test_set_large_index(self):
for inplace in (True, False):
with self.subTest(inplace=inplace):
doc = [0]
self.assertRaises(JsonPointerException, set_pointer,
doc, self.pointer, 1, inplace=inplace)
self.assertEqual(doc, [0])

def test_large_numeric_object_member(self):
doc = {self.token: 'old'}
self.assertEqual(resolve_pointer(doc, self.pointer), 'old')
set_pointer(doc, self.pointer, 'new')
self.assertEqual(doc, {self.token: 'new'})


class ToLastTests(unittest.TestCase):

def test_empty_path(self):
Expand Down
Loading