Normalize oversized array index conversion errors - #83
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The focused exception handling preserves valid mapping keys and is comprehensively tested across affected APIs.
Review effort: Balanced
Findings: None
What changed in this PR
Normalizes oversized array-index conversion failures into JsonPointerException, allowing defaults to work consistently.
Changes:
- Wraps sequence index conversion errors.
- Adds regression coverage for resolution, assignment, nested defaults, and mapping keys.
| File | Description |
|---|---|
jsonpointer.py |
Converts oversized index ValueError into JsonPointerException. |
tests.py |
Adds oversized numeric-token regression tests. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A long numeric array token passes the index syntax check but can exceed Python's integer-string conversion limit. The resulting ValueError escapes resolve()'s JsonPointerException handler, so a supplied default is ignored.
With the default 4300-digit limit, resolve_pointer([0], '/' + '1' * 4301, default=None) currently raises ValueError. This patch returns None; without a default it raises JsonPointerException.
The change catches ValueError only around int(part), preserving Python's safety limit. Five regression tests cover resolution, nested defaults, to_last, both inplace modes, and long numeric mapping keys, which remain valid.
Validation: