Repository navigation
Add deepseek-lossless adapter, web presets, e2e recipe #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
SutuSebastian
wants to merge
93
commits into
main
Choose a base branch
from
feat/deepseek
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
93 commits
Select commit
Hold shift + click to select a range
cbdb2dc
extract DeepSeek adapter spike to its own branch
SutuSebastian 5198eae
name the DeepSeek plan file for what it is, drop the numbering
SutuSebastian 21e0ffc
chore(deepseek): bump dsh pre-releases to 0.2.1-rc.3
SutuSebastian c163a48
chore(deepseek): merge origin/main (version-script lockfile regen)
SutuSebastian d527105
refactor(deepseek): converge adapter onto shared core seams
SutuSebastian fbe3e44
harden(deepseek): simplify converged seams, drop one-caller generic
SutuSebastian 6f80c5f
feat(deepseek): add lcm_expand_query answered retrieval
SutuSebastian b31a249
feat(deepseek): emit metrics rows beside the sidecar
SutuSebastian 70ffa0e
feat(deepseek): add read-only operator verbs to /lcm
SutuSebastian f51dfd0
feat(deepseek): add mutating operator verbs to /lcm
SutuSebastian a1bcf2b
feat(deepseek): recall param parity plus cross-session reads
SutuSebastian 00cb8b8
feat(deepseek): forward seam knobs, caps, and heal budgets
SutuSebastian 2346e18
feat(deepseek): backfill pre-mount history via async observation
SutuSebastian 815fd35
docs(deepseek): record parity decisions and blocked seams
SutuSebastian d42d579
harden(deepseek): fix review findings across parity series
SutuSebastian 57db391
harden: correctness fixes, point reads, docs drift, comment hygiene
SutuSebastian d1af0bd
chore(deps): override zod to ^4.6.6 under dsh parents
SutuSebastian 1d1ede3
docs(roadmap): record harness grafts with pointer-integrity constraint
SutuSebastian d113c22
docs(roadmap): record arena verdict on harness grafts
SutuSebastian 2281c23
fix(deepseek): degrade to live-mirror-only when sessionQuery is uninj…
SutuSebastian bf4f7e4
fix(deepseek): re-derive span mapping from the live log on cold index
SutuSebastian 8db1808
docs(deepseek): record live-proof evidence
SutuSebastian 13cd91a
feat(deepseek): stamp calling session id for per-conversation routing
SutuSebastian a569053
docs(deepseek): record sessionId fix and depth-2 live DAG
SutuSebastian 5d5948f
docs(deepseek): reference section, comparison page, hub wiring
SutuSebastian bc1a98d
chore(deepseek): 0.1.0 publish prep
SutuSebastian 65905d0
docs(deepseek): voice pass, hallmark lessons, comment hygiene
SutuSebastian 8e2802d
docs(deepseek): cover thresholds in skill config essentials
SutuSebastian 9351076
fix(deepseek): write one restorable export per sidecar on gc apply
SutuSebastian 16fbd38
fix(deepseek): mirror descriptor rows for non-text messages
SutuSebastian 9a0f0f4
fix(deepseek): catch-up backfill on unmapped span, single retry
SutuSebastian a5650c3
fix(deepseek): heal route, effective thresholds, store close on dispose
SutuSebastian f8d891c
fix(deepseek): order spans by seq, fix em dash
SutuSebastian ab177e3
fix(deepseek): guard store close with live-run and heal checks
SutuSebastian 1307fac
chore(deepseek): merge origin/main (recall batch #12)
SutuSebastian 80ce497
fix(deepseek): align quote tests with core phrase escaping
SutuSebastian e8bdd37
docs(deepseek): qualify recall, cap, and forget claims
SutuSebastian ed23f30
fix(deepseek): note checkpoint memory only on clean close
SutuSebastian fa9aac8
fix(deepseek): return error result when import throws
SutuSebastian 5edc982
fix(deepseek): verbatim whitespace and coverage-counted backfill
SutuSebastian 78647fa
fix(deepseek): evict closed stores on dispose
SutuSebastian 63e42f7
feat(deepseek): dump verb, gc selectors, dump module split
SutuSebastian df0fd48
feat(deepseek): recall filters and expand anchor
SutuSebastian ec68812
docs(deepseek): attribution, pointer, README sections
SutuSebastian 528d301
fix(deepseek): record failed pass on span-mapping failure
SutuSebastian f4ee254
feat(deepseek): wire mechanicalTools through both pass entries
SutuSebastian bf5f50a
fix(pi): mark async passes stale on mechanicalTools change
SutuSebastian acf283f
fix(deepseek): descriptor rows for blank text
SutuSebastian fd8c73e
fix(core): match tool markers regardless of prose
SutuSebastian 181c025
fix(deepseek): gc hint selectors and strict age parse
SutuSebastian ef1bc39
docs: fix DeepSeek product name
SutuSebastian adbd9ac
harden: review fixes, scope regression guard, comment cull
SutuSebastian 9978210
docs: dump verb, gc selectors, stale branch-state prose
SutuSebastian 4a28fa7
harden: docs drift, peer deps, dump/gc/role fixes, JSDoc, tests
SutuSebastian b81171a
fix(deepseek): gc hint omits inert older-than, backfill reaches past …
SutuSebastian 0302397
fix(deepseek): peer ranges admit the pinned prerelease hosts
SutuSebastian 7141a07
fix(deepseek): MDX-safe rotated log examples in files snippet
SutuSebastian 3163043
fix(deepseek): backfill counts only unmirrored messages, capped by co…
SutuSebastian 849ad6f
docs(deepseek): drop deleted spike branch references from plan
SutuSebastian d662662
harden: visited-budget regression tests, single-derive mirror, ledger…
SutuSebastian 612cae0
harden: result-row opening-line scope rule, compact failure tests, le…
SutuSebastian 132aa71
docs(deepseek): correct model-free reduction cell for opt-in mechanic…
SutuSebastian aa32dab
feat(deepseek): ship profile bundle, plugin entrypoint, and getting-s…
SutuSebastian 963588d
docs(deepseek): add the four missing guide pages so the sidebar match…
SutuSebastian 98ca97d
fix(deepseek): audit findings from four-lane review, peer token-meter…
SutuSebastian ae864f8
fix(docs): truncate the dynamic install command instead of overflowin…
SutuSebastian 6cc65bf
fix(deepseek): drop loader retainRatio default, scope backend switch …
SutuSebastian 12dbeee
docs(deepseek): call the install unit a bundle, matching harness voca…
SutuSebastian 4f826e0
feat(deepseek): full DSH surface support via shared core, realm backe…
SutuSebastian 5b37e5a
chore: record deepseek-web workspace in lockfile
SutuSebastian 508f722
fix(deepseek): one-command install, identity-tied core release, no em…
SutuSebastian 2afc548
docs(deepseek): sync every install path with the auto-enable host patch
SutuSebastian 0b1b0b6
harden: ownership-counted core release, preset docs and surface pins
SutuSebastian 52e62e0
harden: generate lossless presets from pinned harness sources via script
SutuSebastian fd46630
docs(deepseek): state the customization boundaries for presets and th…
SutuSebastian 3ec5202
docs(deepseek): bring-lossless-to-your-preset recipe for customized s…
SutuSebastian 78b14d7
fix(deepseek): close idle stores on last preset release; correct unin…
SutuSebastian 904672e
merge main after PR #14 (sidecar global default)
SutuSebastian 0386313
fix(deepseek): preserve mechanical tool identity; qualify deleted-sid…
SutuSebastian 9fdbbfa
merge main into feat/deepseek
SutuSebastian 5962d2e
fix(deepseek-web): correct ptc backend rows and add preset descriptions
SutuSebastian 749b6d4
fix(deepseek): claim spaced lcm verbs, ptc backend, preset descriptions
SutuSebastian b6634a9
fix(deepseek): write only condensed summary to session log
SutuSebastian 6e29226
fix(deepseek): default sidecar to dsh home lossless
SutuSebastian 323ab3f
fix(deepseek): close pullfrog gaps in bracket, recall, summarizer
SutuSebastian 6944136
fix(deepseek): keep json stdout clean and scope e2e sidecars
SutuSebastian e5020a4
ci: async docs deploy on Release completion via workflow_run
SutuSebastian 1df1710
ci: gate docs build steps on release tag, drop em dashes
SutuSebastian 7560bea
ci: fail-closed smoke check that live site serves this release
SutuSebastian edfc1d3
ci: pin FTP-Deploy-Action to true v4.4.0
SutuSebastian 969f09f
merge main into feat/deepseek
SutuSebastian 3c2c46a
fix(deepseek): gc never deletes a sidecar open in another process; e2…
SutuSebastian 22f4ba3
fix(deepseek): surface gc open-handle skips, re-check before delete; …
SutuSebastian File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,86 @@ | ||
| # Harden ledger | ||
|
|
||
| Local working file. A fresh clone does not carry it; reads become no-ops there. | ||
|
|
||
| ## Rejections | ||
|
|
||
| By-design drops from review passes. Findings matching an entry are dropped | ||
| without re-litigation. | ||
|
|
||
| - Exported-symbol JSDoc stays. Public-API docs on exported functions, types, | ||
| and fields ship in dist typings and hovers; narration flags against them | ||
| are rejected (2026-10-25 full-branch sicko pass). | ||
| - Host line-number pins and drift-rule comments stay. Each marks what mirrors | ||
| the seam so a pin move has a checklist; the pin itself is the mechanism | ||
| note (same pass). | ||
| - Plan-sketch code fences are documentation, not corpses. Fenced sketches in | ||
| docs/deepseek-plan.md describe future shapes; flags against their `//` | ||
| lines are rejected (same pass). | ||
| - MUST KILL reshapes are out of bounds. dshRef, UsageTracker, | ||
| commitDagTransaction, DagStabilityError, resolveSummarizationTarget, | ||
| MessageIndex, resolveEntryId, SpanAlreadyMemoryError, withSummaryRefs, | ||
| cross-session caps, selectDagRange, lcmCommandDefinition, pressureZone, | ||
| writeDumpTarget, whitespace sentinel, mechanicalToolNameOf split, | ||
| SidecarStores opened handles, scopedGrepAll pushdown, toolScopeMessageIds | ||
| scope state, liveStems, valueOf arg parsing, healInFlight guard, | ||
| backfillSession accounting and visited budget: all need new shapes | ||
| (redesigns), so their comments stay and the flags report open (same pass). | ||
| - UI routing comments stay. Sidebar and harness-nav comments record the | ||
| reference-only constraint and cross-file sync points a reader cannot | ||
| re-derive from the loop (same pass). | ||
| - Test-rationale comments stay when they state fixture, divergence, or | ||
| expectation rationale; pure assertion echoes go (same pass). | ||
| - Negative metric limit reads all rows by design. `readMetricRows` treats a | ||
| negative limit as unbounded and zero as empty, pinned by | ||
| `util-metrics-sink.test.ts` (2026-10-25 gauntlet pass 1). | ||
| - Root README names the host ports and bundling once. Day-1 architecture | ||
| needs the two-port contract and the inline-into-dist note; deeper internals | ||
| stay out (same pass). | ||
| - Changesets describe behavior, not just the headline. This repo ships | ||
| detailed per-package entries; the deepseek entry stays behavior-complete | ||
| rather than trimmed to a headline (same pass). | ||
| - backfillSession Budget-type and visitedBudget-function MUST KILLs are | ||
| rejected. The visited/consumed accounting is five explicit lines with the | ||
| rule in one comment plus three regression tests; a Budget type would add | ||
| indirection without removing a branch (2026-10-26 gauntlet). | ||
|
|
||
| ## Deferred | ||
|
|
||
| - Recall scope closer (`toolScopeMessageIds` quoted-marker scan beyond | ||
| toolResult opening lines), bare `tool <name>` matching, cross-session | ||
| `offset`/`summary`/`include_removed` | ||
| forwarding, ghost-session read-only open for minimal deps, dispose-then-close | ||
| for live/healing stores: each | ||
| needs a design decision (sharded past-search semantics, scope state machine, | ||
| lifecycle close scheduling) beyond a polish pass. Recorded open, not fixed. | ||
| Fixed from this row: `/lcm compact` error-code mapping tests (landed with | ||
| the failure-code test), and the toolResult-row half of the scope scan | ||
| (opening-line rule now matches `toolNameOfText`, pinned by regression test). | ||
| - Warm-scan probe cost: a warm remount re-probes every stored row (one indexed | ||
| point lookup each) plus marker derivation, so per-mount work scales with | ||
| history length while only writes and new evaluations are capped. Bounding the | ||
| cheap probes too needs a persisted frontier (resume) design. Progress is | ||
| guaranteed; the cost is accepted until a frontier design lands. | ||
| - Mount fan-out: one backfill per live session runs under one Promise.all. | ||
| Live sessions per composition are inherently few, and serializing would slow | ||
| the common single-session mount. A concurrency cap waits for a composition | ||
| with enough live sessions to matter. | ||
| - Engine cold rescan: the first span miss re-derives the live log to rebuild | ||
| the index. That is the documented cold-start path (fail-closed); changing it | ||
| reshapes documented behavior. | ||
| - dag-commit point mapping: one indexed `messageByEntryId` read per shadowed | ||
| seq. A range rewrite would change the per-seq fail-closed mapping into | ||
| filter semantics; indexed point reads stand until a measured need appears. | ||
| - hydrateCheckpoint full load: cold ladder runs read all stored summaries to | ||
| rebuild one checkpoint. Loading latest-plus-children instead reshapes the | ||
| resume path; the one-time cold cost stands. | ||
| - Lossless preset forks: each `deepseek-lossless-web` preset is a full copy of | ||
| the pinned harness preset with only the backend row swapped (2026-10-26 | ||
| harden pass). Generating them from a base-plus-diff or upstreaming a | ||
| narrower preset-override hook would delete ~400 duplicated lines, but both | ||
| need a design beyond polish (harness-owned composition shape). | ||
| - Host core registry: the module-level shared core with owner counting could | ||
| move onto Cordis scoping once a host-provided service is the established | ||
| pattern for cross-realm sharing. The current shape is explicit and tested; | ||
| reshaping it would change mount/dispose semantics, so it waits for a design | ||
| pass with a live web session behind it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "lossless-core": patch | ||
| --- | ||
|
|
||
| Support the DeepSeek adapter from core. `readMetricRows` takes `session` and `limit` filters, the metrics sink adds usage-tally helpers, `SidecarStores` evicts closed handles, `token-window` selects the compactable range, and `toolNameOfText` is exported for scope matching. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "deepseek-lossless": patch | ||
| --- | ||
|
|
||
| Ship the profile bundle. The package declares `dsh.bundle`, ships its patch layer, icon, locale metadata, and detail doc, and exposes the Cordis plugin shape (`name`, `inject`, `Config`, `apply`) so `dsh plugin --profile <name> add deepseek-lossless` installs as a profile layer instead of a plain dependency. Install stays per profile; the guide covers `web`, `headless`, and custom names plus the enable step that replaces the base compaction backend. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "deepseek-lossless": patch | ||
| --- | ||
|
|
||
| Route the sidecar dir notice through the harness logger so headless `--json` stdout stays clean NDJSON, and scope `run-e2e.sh` sidecars to the scratch `DSH_HOME=/tmp/e2e-dsh` from the README. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "deepseek-lossless": patch | ||
| --- | ||
|
|
||
| Add the DeepSeek adapter. `applyLossless` composes lossless memory into one harness composition, opt-in through `enabled`: every session mirrors into its own sidecar, and the returned disposer stops the mirror, the tools, and the command. It registers `lcm_grep`, `lcm_describe`, `lcm_expand`, and `lcm_expand_query`, plus the `/lcm` verbs `status`, `report`, `dump`, `backup`, `export`, `import`, `gc`, `migrate`, `heal`, `diagnose`, and `compact`. The summarizer engine mounts as the host's compaction backend: automatic pressure compaction stays off until `auto` opts in, manual `/lcm compact` commits through the DAG bracket, and `bracketAuto` routes the automatic path through the bracket too. `mechanicalTools` names noisy tools whose spans compact into deterministic `mechanical` leaves with zero summarizer spend. `lcm_grep` takes `query` with `scope` into past sessions (pattern stays session-scoped) of the same global sidecar directory, where `sessions` and `all_sessions` are equivalent, and `lcm_expand` reads a past session's sidecar read-only through `session`. `lcm_expand_query` runs a bounded in-process reader over `dshReader` and returns findings only. Recall covers grep filters (role, date range, tool name) and anchored expand listings. `/lcm` also grows `dump` with save and removed-row flags, gc session and age selectors, effective-threshold status and diagnose output, a configured heal model fallback, per-sidecar restorable exports, and stores that close on dispose. Model calls stamp the calling session for per-conversation routing, and span-mapping failures record a failed pass row. Sessions already live at mount backfill through the same mirror path, paged and capped, with already-mirrored rows not counting toward the visit ceiling so remounts still reach new events. Every seam writes diagnostic rows to the sidecar directory log, and `/lcm report` rolls up the session's rows. `/lcm diagnose` builds a redacted bundle, `backup`, `export`, and `diagnose --save` write owner-only (0600) files, and `/lcm gc` is age-based and dry-run by default. The composition value-imports its `@deepseek-ai/*` host packages, which stay peer dependencies. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| --- | ||
| "deepseek-lossless": patch | ||
| "deepseek-lossless-web": patch | ||
| --- | ||
|
|
||
| Fix preset teardown leaking open SQLite handles: whichever disposer releases the last core ownership (host or preset) now runs the shared guarded close, so idle stores always close on final release instead of only when the host happens to stop last. Also corrects the uninstall answer to lead with `dsh plugin remove` plus restart, since the shipped bundle patch owns the enable/disable rows and fresh installs create no user rows to delete. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| --- | ||
| "deepseek-lossless": patch | ||
| "deepseek-lossless-web": patch | ||
| --- | ||
|
|
||
| Support every DSH surface. The host composition now runs on a shared core with identity-tied, once-only release, so a stale disposer after a remount cannot evict the replacement, and the last owner alone closes shared handles. A preset-realm backend entrypoint (`deepseek-lossless/preset`) mounts the compaction engine inside agent presets without mirroring twice or closing shared handles; it fails fast naming the host row when the core is absent. The new `deepseek-lossless-web` companion bundle ships Lossless variants of all four shipped presets with only the backend row swapped, pinned to the same harness version as the peers (plus a punctuation normalization the repo requires). Installing the host bundle switches the host-plane backend with no further edits; web and desktop sessions select a Lossless preset. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,5 @@ | ||
| --- | ||
| "deepseek-lossless": patch | ||
| "lossless-core": patch | ||
| "pi-lossless": patch | ||
| "opencode-lossless": patch | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,8 @@ | ||
| --- | ||
| "deepseek-lossless": patch | ||
| "lossless-core": patch | ||
| "pi-lossless": patch | ||
| "opencode-lossless": patch | ||
| --- | ||
|
|
||
| Report orphan sidecars in doctor. `integritySnapshot` now lists sidecar files and stale `wal` and `shm` files with no live session (`.sqlite` by default, `.db` for Pi). `checkIntegrity` reports them as a read-only `orphan-sidecar` finding through `lcm doctor` and the diagnose bundle. Report only. Deletion stays manual. | ||
| Report orphan sidecars in doctor. `integritySnapshot` now lists sidecar files and stale `wal` and `shm` files with no live session (`.sqlite` by default, `.db` for Pi). `checkIntegrity` reports them as a read-only `orphan-sidecar` finding through `lcm doctor` and the diagnose bundle. Report only. Deletion stays manual. DeepSeek carries the finding through the diagnose bundle only, since it has no doctor verb. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,7 @@ | ||
| --- | ||
| "pi-lossless": patch | ||
| "opencode-lossless": patch | ||
| "deepseek-lossless": patch | ||
| --- | ||
|
|
||
| Add a read-only static sidecar dump. `/lcm dump` and `/lossless-dump` open the session sidecar `queryOnly` and reuse the recall views and metric rows. The dump redacts displayed seams, labels removed rows, and reports old generations as named skips. Output is capped at 16 KB. | ||
| Add a read-only static sidecar dump. `/lcm dump` (plus `/lossless-dump` on OpenCode) opens the session sidecar `queryOnly` and reuses the recall views and metric rows. The dump redacts displayed seams, labels removed rows, and reports old generations as named skips. Output is capped at 16 KB. |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dogfood sample finding: anchoring check only.