Repository navigation
Add deepseek-lossless adapter, web presets, e2e recipe - #8
SutuSebastian wants to merge 93 commits into
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
Walkthrough
Merge Risk:
|
🦋 Changeset detectedLatest commit: 22f4ba3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
- ptc preset swaps the unreleased executor row for the pinned presentation row (dsh-agent-tool-presentation, mode ptc) - generator pins the harness checkout to exactly 0.2.1-rc.3 at tag dsh-v0.2.1-rc.3, with content pins that fail fast on master HEAD - 4 preset descriptions, one per lossless preset, rendered by the UI for non built-in ids - publish-surface test asserts every lossless preset declares a non-empty description with no em dash
- lcm command declares input hint <subcommand> ... so spaced verbs route through one handler with bare input on status - ptc preset swaps the unreleased executor row for the pinned dsh-agent-tool-presentation row with mode ptc - generator pins the harness checkout to exactly 0.2.1-rc.3 at tag dsh-v0.2.1-rc.3 - 4 lossless preset descriptions, one per preset, rendered by the UI for non built-in ids - lifecycle shape test asserts the hint plus bare, spaced status, and dump dispatch - e2e probes use a portable tarball path with a runner that checks pong finals and sidecars
Each bracket writes a single condensed summary to the session log and keeps leaves sidecar only in sqlite. Adds a two-compaction regression test pinning one log summary per bracket. Resolves loader repeats that re-read leaf records on harness reload.
Default sidecarDir is the global dsh home path ($DSH_HOME/lossless, else ~/.dsh/lossless) with ./.lossless only as fallback. First publish ships no legacy path, so the startup CWD warning and migrate hint are gone; mount keeps the one startup log line with dir plus source.
Bracket span mapping retries once through history backfill before throwing. Manual taxonomy rethrows already-memory so it matches the auto path. Recall wiring reads through peek so lookups create no empty sidecar. Half-set summarizer pair falls back to the agent route.
There was a problem hiding this comment.
ℹ️ No critical issues — two minor inconsistencies inline, both in new delta files. Prior feedback is fully addressed.
Reviewed changes since the prior Pullfrog review (9fdbbfa..323ab3f, five commits):
- Bracket writes one condensed summary per pass with leaves sidecar-only, keeping the single-summary session log shape plus sidecar ids on the result for metrics.
- Sidecar default moved to the dsh home (
$DSH_HOME/lossless, else~/.dsh/lossless, else./.lossless) via a pure resolver with tests. - Preset surface corrected to the pinned harness rows with per-preset descriptions, and the sync script now pins the exact harness tag with fail-fast row guards.
- Manual e2e probes added as recipes plus a runner script against real
dshprofiles. - Prior review gaps closed: DAG catch-up backfill, already-memory rethrow, half-set summarizer fallback, and peek-based recall wiring (threads retired).
No specialist pass was needed: the delta is narrow, and each prior fix was verified by direct reads against the checked-out code.
muse-spark-1.3-contributor | 𝕏
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes since the prior Pullfrog review (323ab3f..6944136, one commit):
- Routed the sidecar-dir notice through the harness logger instead of
console.log, keeping headless--jsonstdout clean NDJSON, with a regression test asserting nothing reachesconsole.logorstdout. - Scoped the e2e runner to a scratch
DSH_HOME(/tmp/e2e-dsh/lossless) for sidecar creation and assertions, replacing the stale/tmp/.losslesspath, with string-guard tests on the script. - Added a patch changeset describing both fixes.
Both prior threads were verified fixed against the checked-out code and retired. One verification limit: the new engine logger test was checked by reading only, since the sandbox lacks the private @deepseek-ai/* harness packages needed to execute the deepseek suite.
muse-spark-1.3-contributor | 𝕏
There was a problem hiding this comment.
✅ No new issues found. The single-commit CI delta is sound and narrowly scoped.
Reviewed changes since the prior Pullfrog review (6944136..e5020a4, one commit):
- Added async docs deploy on Release completion via a
workflow_runtrigger, covering changesets releases created withGITHUB_TOKENthat spawn norelease: publishedrun.- Pinned the follow-up checkout to the triggering run head SHA with tags fetched, so the sitemap
git logand the release-tag gate read the released commit.- Gated the FTP upload on a release-tag check that skips green when the head carries no tag, leaving the existing
release,pull_request, andworkflow_dispatchpaths untouched.Verified by direct read of
.github/workflows/deploy-docs.ymlagainst the checked-out code: the gate script is static with no untrusted interpolation, the skipped-step output comparison (!= 'false') preserves the non-workflow_runupload path, andgit diff 6944136..e5020a4 --statconfirms one file with no product-code surface. No specialist pass was needed.
muse-spark-1.3-contributor | 𝕏
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes since the prior Pullfrog review (e5020a4..1df1710, one commit):
- Gated the full docs build on the release tag so non-release
Releasecompletions skip Setup, validate, typecheck, build, and audit green instead of rebuilding the site. - Removed em dashes from the added workflow comments per the repo prose rule.
Verified by direct read of .github/workflows/deploy-docs.yml against the checked-out head: the != 'false' comparison preserves the non-workflow_run paths (skipped gate yields empty output), and the tag check reads the pinned run head SHA with tags fetched. No specialist pass was needed: single-file CI delta, fully verifiable by read. The two human-side threads noting these Greptile findings as fixed in this commit were confirmed accurate and left for the author to resolve.
muse-spark-1.3-contributor | 𝕏
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes since the prior Pullfrog review (1df1710..7560bea, one commit):
- Added a fail-closed deploy proof that the live site serves this release, gated on the same release-tag check so non-release runs skip green.
- Handled both head shapes: tagless heads assert site liveness only, while tagged heads require each
git tag --points-at HEADentry to appear on/changelogwith retries.
Verified by direct read of .github/workflows/deploy-docs.yml against the checked-out head: quoted tag expansion with fixed-string grep -qF, -f curl flags on both branches, and no product-code surface. No specialist pass was needed: single-file CI delta, fully verifiable by read. No open Pullfrog threads remain.
muse-spark-1.3-contributor | 𝕏
There was a problem hiding this comment.
✅ No new issues found.
The delta since the prior review is a deploy-only CI fix with no product-code impact.
Reviewed changes since the prior Pullfrog review (7560bea..edfc1d3, one commit):
- Pinned the FTP deploy action from tag
v4.4.0to its full commit SHA, matching the SHA pin style already used foractions/checkoutin the same file. - Added the missing FTP username input (
FTP_USERNAMEsecret) beside the existing host and password secrets, so the upload step authenticates with a complete credential set.
No specialist pass was needed: the delta is a two-line CI change, fully verifiable by direct read of the workflow file.
muse-spark-1.3-contributor | 𝕏
SutuSebastian
left a comment
There was a problem hiding this comment.
✅ No new issues found.
Confidence: 4/5 · Safety: no new attack surface (no auth/secrets handling; sidecar paths sanitized; no network except model calls).Basis: 0 reproduced · 0 ran · 0 walked · 0 pointed · 0 said · 0 rules cited · 0 verified fixes
Reviewed changes — DeepSeek adapter with per-session SQLite mirror and DAG-bracket compaction, plus core recall/metrics seams, generated web presets, docs, and changesets:
- DeepSeek adapter (
packages/deepseek/src/): async backfill mirror, ladder overdshModelHost, DAG bracket plus engine override, four recall tools, eleven/lcmverbs. - Core seams (
packages/core/src/): scope machine with removed-row handling, metric filters and tally helpers,SidecarStoresevict/clear, compactable-range selector. - Web presets and docs: pinned-harness presets with sync guards, guides/reference/skill, per-package changesets.
- Prior bot threads (bracket backfill, SAM rethrow, summarizer fallback, peek recall, logger routing, e2e scoping) verified fixed in the diff; two lens passes (bracket adversarial, sidecar file-safety) held with only informational notes kept off-PR.
What we checked
dag-commit.ts— transaction, taxonomy, stability checks (source)engine.ts+ladder.ts— override, unwrap, budgets, commit ordering (source)ingest.ts+plugin.ts+core.ts— mirror, backfill caps, refcounting (source)lifecycle.ts+tools.ts— verbs, recall, gc/migrate/heal (source)recall-view.ts,metrics-sink.ts,token-window.ts,sidecar-store.ts— seam changes (source)packages/deepseek/test/(249 its) +packages/core/test/— co-located coverage (test)
Reviewed with Verdict 0.3.1 · deep tier · cost unrecorded · 100 files
…e uses a fresh scratch dir and checks metrics
There was a problem hiding this comment.
Important
The new cross-process gc guard is the right fix, but its own regression test fails at this head, so CI is red until the test is fixed.
Reviewed changes since the prior Pullfrog review ([edfc1d3](edfc1d338db6f55d259 expected7e143afc)..3c2c46a, one merge plus one fix commit):
- Added a cross-process open guard to gc: candidates with a live
-shmfile are skipped, and an explicit--sessiontarget held open elsewhere fails closed. - Hardened the e2e runner with a fresh scratch sidecar dir per run, a freshness assertion on probe 3 sidecars, and a non-empty
metrics.jsonlcheck. - Added a regression test covering the open-sidecar skip plus the named-target refusal.
All prior Pullfrog threads are resolved with no action needed. No specialist pass was needed: the delta is three files, and the one finding below was verified by executing the test twice plus a filesystem probe.
muse-spark-1.3-contributor | 𝕏
…e2e probe 4 warms backfill metrics
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes since the prior Pullfrog review (3c2c46a..22f4ba3, one commit):
- Surfaced the gc cross-process skip count in dry-run, nothing-eligible, and apply tails, and re-checks
-shmimmediately before the delete path. - Moved the e2e metrics assertion to a new probe 4 second pong that warms backfill metrics even on full dedup.
- Fixed the prior failing regression test by re-aging the sidecar after
close()and asserted the held-open skip note.
muse-spark-1.3-contributor | 𝕏
SutuSebastian
left a comment
There was a problem hiding this comment.
verdict dogfood test (Go port) — please ignore. One sample finding to exercise anchoring and posting.
Reviewed with Verdict 0.3.1 · standard tier · cost unrecorded · 122 files
| @@ -15,6 +15,7 @@ Each doc has exactly one job, keep content in its lane: | |||
| | `packages/*/CHANGELOG.md` | Each package's version history, written by changesets | Marketing prose, roadmap | | |||
| | `apps/docs/content/reference/pi/comparison.mdx` | Audited Pi peer comparison; the page and the source are one file | Feature marketing, unverified cells | | |||
There was a problem hiding this comment.
Dogfood sample finding: anchoring check only.

Summary
Adds the
deepseek-losslessadapter (per-session SQLite sidecar mirror, DAG compaction through the harness seam plus a DAG-bracket manual path, four recall tools,/lcmverbs) anddeepseek-lossless-web(Lossless variants of all four shipped presets on an identity-tied shared core). Selecting a Lossless preset is the opt-in; host-plane profiles need only the host bundle.Evidence
/lcmverbs claimed, no recall tools.After: pong probes plus sidecar checks pass per the recipe (shipped headless profile, plain base plus overlay, lossless bundle; each asserts the final pong event plus sidecar sqlite and metrics.jsonl checks). Live runs on installed dsh 0.2.1-rc.3 over Go and OpenRouter routes: auto pressure stored leaves plus condensed nodes with checkpoint replaces across 4 swaps (depth-2 DAG: 61 summaries, 47 leaves, 14 condensed, billed usage); a zero-context session answered verbatim with cross-session entry citations; the in-process reader answered through the Go route after the calling session id stamp fixed the MissingSessionID 400s. Note: on 2026-10-27 the headless probes hung with zero output even without the bundle, pointing at the environment rather than the plugin; live web proof stays owner-side and presets are pinned by unit tests.
Targeted pins verified this pass:
packages/deepseek/test/preset.test.tsplusdefault-sidecar-dir.test.ts(24 passed), covering Lossless preset loading and the dsh home sidecar default. Defaults run mirrored without compacting. Boot and span defects found live are fixed with tests.Merge Danger
Door: two-way
Unreleased 0.1.0, no registry binding yet, so revert is a branch delete. Owner steps before merge: bind npm trusted-publisher for
deepseek-lossless0.1.0 anddeepseek-lossless-web0.1.0, then manual publish. Roadmap item 10 stays tracking until merge.Blast Radius: deepseek-only
New surface is
packages/deepseekandpackages/deepseek-webplus docs andscripts/sync-lossless-presets.ts. Shared seams are small and host-free: metric row filters, usage-tally sink helpers, SidecarStores eviction, compactable range selection, and a toolNameOfText export inpackages/core, plus a 3-line config-io tweak inpackages/pi. No behavior change for existing users: the adapter is opt-in with enabled, auto, and bracketAuto off.Summary by CodeRabbit
New Features
/lcmcommands for status, reports, backups, exports, imports, diagnostics, sidecar maintenance, and manual compaction. Maintenance operations default to dry-run where applicable.Bug Fixes


Confidence Score: 5/5
The follow-up adds no new blocking issue; the two earlier non-blocking findings remain open.Summary
Adds the DeepSeek adapter and Lossless web presets, with per-session SQLite history, compaction, four recall tools, and
/lcmcommands./lcmcommands.Diagram
%%{init: {'theme': 'neutral'}}%% flowchart LR Session[Session events] --> Mirror[History mirror] Mirror --> Store[Per-session SQLite] Host[Host backend] --> Core[Shared core] Preset[Lossless preset backend] --> Core Core --> Store Store --> Recall[Four recall tools] Store --> Ladder[Summary ladder] Ladder --> Checkpoint[Conversation checkpoint]Reviews (38) · Last reviewed commit: "fix(deepseek): surface gc open-handle sk..." · Reviewed by Greptile