fix(fleet): fan out on a dispatched Release and fail closed on a no-op - #464
Merged
Merged
Conversation
Two fleet-gate reliability fixes. Resolve gate: accept a source Release started by workflow_dispatch, not only by a tag push. When the candidate tag points at a state commit whose message suppresses CI, the tag-push trigger does not fire and orchestrate dispatches Release explicitly against the tag; that arrives here as event workflow_dispatch and must fan the fleet out exactly like the push path. A dispatch against a non-candidate ref still fails the head_branch candidate check and does not fan out. Fleet gate: run always and fail closed on a no-op. A skipped aggregate job reads as success, so a run that resolved no candidate and ran no lanes previously concluded green having validated nothing. The gate now runs unconditionally and, in a context obligated to validate a candidate (a manual dispatch, or a green Release for an rc/dryrun tag), requires a resolved candidate version and at least one fan-out lane run to success, else it reds. A context with nothing to validate stays a clean green no-op. This mirrors the reconcile require-ledger guard. Verification: actionlint on fleet-e2e.yaml clean. Signed-off-by: Joshua Temple <joshua.temple@stablekernel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Two fleet-gate reliability defects surfaced publishing v0.8.0.
Bug 2 - a dispatched Release never fans out the fleet. The
resolvejob gates ongithub.event.workflow_run.event == 'push'. When the rcReleaseis started by an explicitworkflow_dispatchagainst the tag (the reliable trigger, since a tag-push is suppressed when the tag points at a CI-skip state commit), the source run's event isworkflow_dispatch, the gate is false,resolveis skipped, and noversion-under-testartifact is produced.auto-promotethen cannot identify the validated rc.Bug 3 - the fleet reports SUCCESS when it validated NOTHING. Because
aggregatewas gated onneeds.resolve.result == 'success', a skippedresolve(the Bug 2 symptom) skipped the gate too, and a skipped job reads as success. The rc.7 fleet run resolved no rc, skipped every lane, skipped the Fleet gate, and still concluded green. That false green is what let v0.8.0 publish on a no-op.Fix
Releasestarted bypushORworkflow_dispatchfor an rc/dryrun tag. A dispatch against a non-candidate ref (the finalvX.Y.Ztag, ormain) still fails the head_branch candidate check and does not fan out.if: always()so it renders a verdict rather than inheriting a skip, and fail closed. In a context obligated to validate a candidate (a manual dispatch, or a greenReleasefor an rc/dryrun tag), it now requires a resolved candidate version AND at least one fan-out lane run to success, else it reds. A context with nothing to validate stays a clean green no-op. This mirrors the reconcilerequire-ledgerguard.Bug 3 is the defense-in-depth for Bug 2: Bug 2 removes the cause (missing artifact / skipped resolve), Bug 3 ensures the symptom (a false-green no-op gate) can never recur.
Verification
actionlintonfleet-e2e.yamlis clean.Notes
Release-path change: warrants a fleet validation run before it is considered fully accepted. Land this before (or with) the companion trigger PR
fix/release-trigger-reliability, whose explicit candidate dispatch depends on this broadened resolve gate to fan the fleet out.