fix(release): dispatch the release workflow for a candidate tag - #465
Merged
Merged
Conversation
The orchestrate finalize job cuts the release-candidate tag on the setup head SHA, which in steady state is a prior state commit whose message carries a CI-skip marker. GitHub evaluates that marker on the tagged commit and suppresses every workflow the tag push would start, so the tag-push trigger that builds and publishes the candidate never fires. Recent candidates produced zero downstream release runs as a result. When release.workflow is configured and the trunk is dispatch-driven, finalize now dispatches that workflow explicitly against the candidate tag (gh workflow run --ref), mirroring the promote flow's post-publish dispatch. The dispatch is gated to dispatch-mode trunks so it never races a push-mode trunk's native tag trigger, and to real GitHub so the act e2e harness is unaffected. Wire cascade's own manifest to its release workflow and regenerate. Verification: go build, go test ./internal/generate ./internal/config, golangci-lint, actionlint on the regenerated workflows, and cascade verify (no drift) all clean. Signed-off-by: Joshua Temple <joshua.temple@stablekernel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The orchestrate finalize job cuts the release-candidate tag on the setup head SHA. In steady state that SHA is a prior
chore: update statecommit whose message carries a CI-skip marker. GitHub evaluates the marker on the tagged commit and suppresses every workflow the tag push would start, so the tag-push trigger that builds and publishes the candidate never fires. Recent candidates (v0.8.0-rc.6/rc.7) produced zero downstreamReleaseruns for exactly this reason; rc.5 only worked because it happened to tag a normal commit.Fix
When
release.workflowis configured and the trunk is dispatch-driven (release_trigger: dispatch), the finalize job now dispatches that workflow explicitly against the candidate tag (gh workflow run --ref), mirroring the promote flow's existing post-publish dispatch. This is the dependable trigger regardless of the tagged commit's message.github.server_url) so the act e2e harness, which has no workflow-dispatch API, is unaffected.release.workflow. cascade's own manifest is wired to itsrelease.yamland the workflows regenerated.Verification
go build ./...,go test ./internal/generate ./internal/config(941 pass),golangci-lint run,actionlinton the regenerated workflows (no new findings), andcascade verify(3 files, no drift) all clean. New generator unit tests cover the emit/omit matrix and path normalization.Notes
Release-path change: warrants a fleet validation run before it is considered fully accepted. This depends on
fix/release-trigger-reliability's companion PR #464: the dispatchedReleasearrives at the fleet as anevent: workflow_dispatchsource run, which #464's broadened resolve gate must accept to fan the fleet out and produce theversion-under-testartifact. Land #464 first (or together); this PR alone would fire the candidate build but the fleet would not validate it until #464 is in.The regenerated
promote.yamlgains the already-specifiedTrigger Release Buildstep as a side effect of settingrelease.workflow; it is guarded onis_final_envand inert for cascade (no environments; final publish runs through the hand-writtenauto-promote.yaml).