Skip to content

fix(fleet): retry repin verify read-back to absorb contents-API lag #358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joshua-temple merged 1 commit into from
Jun 25, 2026
Merged

fix(fleet): retry repin verify read-back to absorb contents-API lag #358

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 18 additions & 10 deletions .github/workflows/fleet-e2e.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,17 +301,25 @@ jobs:
# Confirm the repo's main actually carries the rc cli_version after the
# push. Belt-and-suspenders: a silent no-op (push that landed nothing)
# can never report green because this reads the published main back.
# The contents API can serve stale cached bytes for a few seconds after
# a push, so retry the read-back with linear backoff (matching the push
# loop) rather than redding the fleet on a single lagged read.
verify_pinned() {
local slug="$1" actual
actual=$(gh api "repos/${slug}/contents/.github/manifest.yaml" \
--jq '.content' | base64 -d \
| grep -E "^[[:space:]]*cli_version:" | head -n 1 \
| sed -E 's|^[[:space:]]*cli_version:[[:space:]]*||' | tr -d '"' | tr -d "'") || return 1
if [ "$actual" != "$RC_VERSION" ]; then
echo "::error::${slug} main cli_version is '${actual}', expected '${RC_VERSION}'"
return 1
fi
echo "${slug} main verified at ${RC_VERSION}"
local slug="$1" actual attempt
for attempt in $(seq 1 "$MAX_ATTEMPTS"); do
actual=$(gh api "repos/${slug}/contents/.github/manifest.yaml" \
--jq '.content' | base64 -d \
| grep -E "^[[:space:]]*cli_version:" | head -n 1 \
| sed -E 's|^[[:space:]]*cli_version:[[:space:]]*||' | tr -d '"' | tr -d "'") || actual=""
if [ "$actual" = "$RC_VERSION" ]; then
echo "${slug} main verified at ${RC_VERSION} (attempt ${attempt})"
return 0
fi
echo "verify attempt ${attempt}/${MAX_ATTEMPTS} for ${slug}: read '${actual}', want '${RC_VERSION}'"
sleep "$attempt"
done
echo "::error::${slug} main cli_version is '${actual}', expected '${RC_VERSION}' after ${MAX_ATTEMPTS} attempts"
return 1
}

failed=""
Expand Down
Loading