fix(fleet): retry repin verify read-back to absorb contents-API lag - #358
Merged
Merged
Conversation
The repin pushes the rc cli_version to each example repo then reads main back to confirm it landed. The GitHub contents API can serve stale cached bytes for a few seconds after a push, so a single lagged read reds the whole fleet on a random repo each run even though every push succeeded. Retry the verify read with linear backoff (reusing MAX_ATTEMPTS, the same resilience the push loop already has) and only error after all attempts. Signed-off-by: Joshua Temple <joshua.temple@stablekernel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The fleet repin pushes the rc
cli_versionto each example repo, then reads main back to confirm it landed. The GitHub contents API serves stale cached bytes for a few seconds after a push, so a single lagged read reds the entire fleet on a random repo each run even though every push succeeded. Observed twice in a row on different repos (rc.2 run: 3env/single-env/no-env; rc.4 run: 2env/callbacks), with all repos confirmed at the target version immediately after.Fix
Retry the verify read with linear backoff, reusing
MAX_ATTEMPTS(the same resilience the push loop already has). Succeed as soon as the read settles to the expected version; only error after all attempts.Verification
actionlint clean. The next rc fleet run exercises the repin path end to end; all ten repos are already at the target rc, so the verify now passes instead of flaking.