Skip to content

fix(generate): disable pyflakes in actionlint test for hermeticity #341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joshua-temple merged 1 commit into from
Jun 24, 2026
Merged

fix(generate): disable pyflakes in actionlint test for hermeticity #341

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions internal/generate/generator_normalize_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,10 +102,15 @@ func TestNormalizeWorkflowPath_ActionlintClean(t *testing.T) {
t.Fatalf("WriteFile: %v", writeErr)
}

// Disable the shellcheck integration: this test governs workflow structure
// and uses: reference validity, not the style of cascade-owned run: scripts
// (which carry their own pre-existing SC2129-style notes).
out, runErr := exec.Command(actionlint, "-shellcheck=", path).CombinedOutput()
// Disable the optional external-linter integrations (shellcheck and
// pyflakes): this test governs workflow structure and uses: reference
// validity, not the style of cascade-owned run: scripts (which carry their
// own pre-existing SC2129-style notes). Leaving these integrations on the
// default-enabled setting makes the result depend on whether (and which
// version of) shellcheck/pyflakes happens to be installed in the runner,
// which is the source of the cross-environment flakiness. -no-color keeps
// the captured output stable for the failure message.
out, runErr := exec.Command(actionlint, "-shellcheck=", "-pyflakes=", "-no-color", path).CombinedOutput()
if runErr != nil {
t.Errorf("actionlint found errors in generated workflow:\n%s", out)
}
Expand Down
Loading