fix(generate): disable pyflakes in actionlint test for hermeticity - #341
Merged
Merged
Conversation
TestNormalizeWorkflowPath_ActionlintClean left actionlint's -pyflakes at its default (enabled), so in sandboxes where pyflakes is on PATH it emitted extra findings and flipped the test pass/fail on ambient tooling. Pass -pyflakes= (mirroring the existing -shellcheck=) plus -no-color; the native structural and reference checks are unchanged. Closes #337. Signed-off-by: Joshua Temple <joshua.temple@stablekernel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
TestNormalizeWorkflowPath_ActionlintCleanleft actionlint's-pyflakesat its default (enabled). In sandboxes wherepyflakesis on PATH, actionlint picked it up and emitted extra findings, flipping the test pass/fail on ambient tooling. A pure environment-dependency flake.Fix
Pass
-pyflakes=(mirroring the existing-shellcheck=) plus-no-colorfor stable output. The native structural and reference-validity checks are unchanged; the assertion is not weakened.go test -run TestNormalizeWorkflowPath -count=5passes (35/35). Closes #337.