Skip to content

refactor(do): make DoConnectOptions a non-exhaustive unit struct #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iamralch merged 1 commit into from
Sep 26, 2026
Merged

refactor(do): make DoConnectOptions a non-exhaustive unit struct #12

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions crates/sqlx-cloudflare-do/src/connection.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,10 +122,12 @@ impl Connection for DoConnection {
/// [`connect`](ConnectOptions::connect) always fails: a connection comes from
/// a Durable Object's storage, which only the object itself holds. Use
/// [`DoConnection::new`].
///
/// Non-exhaustive, so parsing is the only way to get one -- as sqlx itself
/// does -- and a field can be added without breaking anyone.
#[derive(Debug, Clone, PartialEq, Eq)]
pub struct DoConnectOptions {
_private: (),
}
#[non_exhaustive]
pub struct DoConnectOptions;

impl FromStr for DoConnectOptions {
type Err = Error;
Expand All @@ -141,7 +143,7 @@ impl ConnectOptions for DoConnectOptions {

fn from_url(url: &Url) -> Result<Self, Error> {
if url.scheme() == "do" {
Ok(Self { _private: () })
Ok(Self)
} else {
Err(Error::Configuration(
format!("expected a `do://` URL, got scheme `{}`", url.scheme()).into(),
Expand Down
Loading