Repository navigation
refactor(do): make DoConnectOptions a non-exhaustive unit struct - #12
Merged
Merged
Conversation
`#[non_exhaustive]` says what the private `_private: ()` field only implied: code outside the crate cannot construct one, so parsing a `do://` URL stays the only way to get it, and a field can be added later without a breaking change. Nothing changes for users.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces
pub struct DoConnectOptions { _private: () }with#[non_exhaustive] pub struct DoConnectOptions;.Both keep code outside the crate from constructing it: parsing a
do://URL stays the only way to get one, and a field can be added later without breaking anyone.#[non_exhaustive]says that directly instead of relying on a dummy field. Nothing changes for users.refactor:, so it triggers no release.