Skip to content

Clean up remaining agent -> runner references #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mivds wants to merge 1 commit into
base: main
Choose a base branch
from
+10 −10
Open

Clean up remaining agent -> runner references #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions go/cmd/datasource.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ Example config:

result, err := client.CreateDatasource(api.CreateDatasourceRequest{
Name: name,
AgentID: runnerID,
RunnerID: runnerID,
ConfigurationFileContents: string(configBytes),
})
if err != nil {
Expand Down Expand Up @@ -195,7 +195,7 @@ var dsTestConnectionCmd = &cobra.Command{
fmt.Println(output.Dim.Render(" Testing connection from " + configFile + "..."))

operationID, err := client.TestConnection(api.TestConnectionRequest{
AgentID: runnerID,
RunnerID: runnerID,
ConfigurationFileContents: string(configBytes),
})
if err != nil {
Expand Down Expand Up @@ -299,7 +299,7 @@ var dsUpdateCmd = &cobra.Command{
req.Label = v
}
if v, _ := cmd.Flags().GetString("runner"); v != "" {
req.AgentID = v
req.RunnerID = v
}
if v, _ := cmd.Flags().GetString("config"); v != "" {
configBytes, err := os.ReadFile(v)
Expand Down Expand Up @@ -594,7 +594,7 @@ func init() {
dsCreateCmd.Flags().String("runner", "", "Route connection through a Soda Runner")
dsTestConnectionCmd.Flags().String("runner", "", "Soda Runner ID to route the test through")
dsUpdateCmd.Flags().String("label", "", "New label for the datasource")
dsUpdateCmd.Flags().String("runner", "", "Agent/runner ID to route through")
dsUpdateCmd.Flags().String("runner", "", "Runner ID to route through")
dsUpdateCmd.Flags().String("config", "", "YAML connection config file")

dsDiagnosticsCmd.Flags().Bool("enable", false, "Enable the diagnostics warehouse")
Expand Down
2 changes: 1 addition & 1 deletion go/cmd/datasource_onboard.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ selecting all discovered datasets and applying the requested settings.
fmt.Println(output.Dim.Render(" Creating datasource '" + name + "'..."))
createResult, err := client.CreateDatasource(api.CreateDatasourceRequest{
Name: name,
AgentID: runnerID,
RunnerID: runnerID,
ConfigurationFileContents: string(configBytes),
})
if err != nil {
Expand Down
2 changes: 1 addition & 1 deletion go/cmd/runner.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ var runnerCreateCmd = &cobra.Command{
fmt.Println()
fmt.Println(output.Dim.Render(" Next steps:"))
fmt.Println(output.Dim.Render(" To connect this runner, deploy the Soda Runner Helm chart on your Kubernetes cluster."))
fmt.Println(output.Dim.Render(" Docs: https://docs.soda.io/deployment-options/soda-agent/deploy-soda-agent"))
fmt.Println(output.Dim.Render(" Docs: https://go.soda.io/agent"))
return nil
},
}
Expand Down
6 changes: 3 additions & 3 deletions go/internal/api/datasources.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ func (c *Client) GetDatasource(datasourceID string) (*Datasource, error) {
}

type UpdateDatasourceRequest struct {
AgentID string `json:"runnerId,omitempty"`
RunnerID string `json:"runnerId,omitempty"`
ConfigurationFileContents string `json:"configurationFileContents,omitempty"`
Label string `json:"label,omitempty"`
}
Expand Down Expand Up @@ -161,7 +161,7 @@ func (c *Client) OnboardDiscoveredDatasets(datasourceID string, req OnboardDatas

type CreateDatasourceRequest struct {
Name string `json:"name"`
AgentID string `json:"runnerId"`
RunnerID string `json:"runnerId"`
ConfigurationFileContents string `json:"configurationFileContents"`
Label string `json:"label,omitempty"`
}
Expand Down Expand Up @@ -190,7 +190,7 @@ func (c *Client) CreateDatasource(req CreateDatasourceRequest) (*CreateDatasourc
// ── Test connection (async) ──────────────────────────────────────────────────

type TestConnectionRequest struct {
AgentID string `json:"runnerId"`
RunnerID string `json:"runnerId"`
ConfigurationFileContents string `json:"configurationFileContents"`
}

Expand Down
2 changes: 1 addition & 1 deletion skills/soda-cli/command-reference.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -384,7 +384,7 @@ List registered Soda Runners. Returns: id, name, status, version, last seen.
Show details for a specific runner.

### `sodacli runner create --name <name>`
Create runner credentials for Kubernetes deployment. Returns API key ID + secret (shown once). The runner appears in `runner list` only after the Helm chart is deployed and the agent connects to Soda Cloud.
Create runner credentials for Kubernetes deployment. Returns API key ID + secret (shown once). The runner appears in `runner list` only after the Helm chart is deployed and the runner connects to Soda Cloud.

### `sodacli runner delete <runner-id>`
Delete a runner.
Expand Down