Skip to content

use chainlink-aptos/codec & chainlink-sui/codec modules#23011

Merged
jmank88 merged 1 commit into
developfrom
aptos-codec-module
Jul 8, 2026
Merged

use chainlink-aptos/codec & chainlink-sui/codec modules#23011
jmank88 merged 1 commit into
developfrom
aptos-codec-module

Conversation

@jmank88

@jmank88 jmank88 commented Jul 1, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

This PR eliminates one chainlink-aptos module import, by switching over to the lighter-weight and more stable chainlink-aptos/codec module.

Note there are still four more imports to resolve:
Screenshot 2026-07-01 at 3 26 17 PM
Same for sui

Requires:

@jmank88 jmank88 mentioned this pull request Jul 1, 2026
Merged
2 tasks
@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

I see you updated files related to core. Please run make gocs in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

✅ No conflicts with other open PRs targeting develop

@trunk-io

trunk-io Bot commented Jul 1, 2026 •
edited
Loading

Copy link
Copy Markdown

Static Badge   Static Badge   Static Badge   Static Badge

Failed Test Failure Summary Logs
Test_CCIPTokenTransfer_Sui2EVM_BurnMintTokenPool_WithAllowlist_AfterSignerAdded The test failed without a specific error message indicating what went wrong. Logs ↗︎

View Full Report ↗︎ ⋅ Docs

@jmank88 jmank88 requested review from archseer and ogtownsend July 1, 2026 20:49
@jmank88 jmank88 mentioned this pull request Jul 2, 2026
Merged
2 tasks
@jmank88 jmank88 force-pushed the aptos-codec-module branch 7 times, most recently from 899509f to 1831016 Compare July 8, 2026 15:47
@jmank88 jmank88 force-pushed the aptos-codec-module branch from 1831016 to a8eb0f7 Compare July 8, 2026 15:50
JohnChangUK
JohnChangUK previously approved these changes Jul 8, 2026
View reviewed changes
@jmank88 jmank88 force-pushed the aptos-codec-module branch from a8eb0f7 to 795fa17 Compare July 8, 2026 16:00
@jmank88 jmank88 force-pushed the aptos-codec-module branch from 795fa17 to 2d436b2 Compare July 8, 2026 16:12
@github-actions

github-actions Bot commented Jul 8, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

CORA - Pending Reviewers

All codeowners have approved! ✅

Legend: ✅ Approved | ❌ Changes Requested | 💬 Commented | 🚫 Dismissed | ⏳ Pending | ❓ Unknown

For more details, see the full review summary.

@jmank88 jmank88 marked this pull request as ready for review July 8, 2026 16:13
@jmank88 jmank88 requested review from a team as code owners July 8, 2026 16:13
@cl-sonarqube-production

cl-sonarqube-production Bot commented Jul 8, 2026

Copy link
Copy Markdown

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube

@jmank88 jmank88 enabled auto-merge July 8, 2026 17:44
@jmank88 jmank88 requested a review from JohnChangUK July 8, 2026 17:44
@jmank88 jmank88 changed the title use chainlink-aptos/codec module use chainlink-aptos/codec & chainlink-sui/codec modules Jul 8, 2026
@jmank88 jmank88 added this pull request to the merge queue Jul 8, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jul 8, 2026
@jmank88 jmank88 added this pull request to the merge queue Jul 8, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jul 8, 2026
@jmank88 jmank88 added this pull request to the merge queue Jul 8, 2026
Merged via the queue into develop with commit 29dae74 Jul 8, 2026
222 of 224 checks passed
@jmank88 jmank88 deleted the aptos-codec-module branch July 8, 2026 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ogtownsend ogtownsend ogtownsend approved these changes
@pavel-raykov pavel-raykov pavel-raykov approved these changes
@archseer archseer Awaiting requested review from archseer
@FelixFan1992 FelixFan1992 Awaiting requested review from FelixFan1992
@carte7000 carte7000 Awaiting requested review from carte7000 carte7000 is a code owner automatically assigned from smartcontractkit/ccip-offchain
@matYang matYang Awaiting requested review from matYang matYang is a code owner automatically assigned from smartcontractkit/ccip-offchain
@makramkd makramkd Awaiting requested review from makramkd makramkd is a code owner automatically assigned from smartcontractkit/ccip-offchain
@AmrMohamedRezk AmrMohamedRezk Awaiting requested review from AmrMohamedRezk AmrMohamedRezk is a code owner automatically assigned from smartcontractkit/ccip-offchain
@tt-cll tt-cll Awaiting requested review from tt-cll tt-cll is a code owner automatically assigned from smartcontractkit/ccip-offchain
@chris-de-leon-cll chris-de-leon-cll Awaiting requested review from chris-de-leon-cll chris-de-leon-cll is a code owner automatically assigned from smartcontractkit/ccip-offchain
@Tofel Tofel Awaiting requested review from Tofel
@george-dorin george-dorin Awaiting requested review from george-dorin
@justinkaseman justinkaseman Awaiting requested review from justinkaseman
@JohnChangUK JohnChangUK Awaiting requested review from JohnChangUK

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jmank88 @JohnChangUK @ogtownsend @pavel-raykov