Codec Module#493
Merged
Merged
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+41
to
+65
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Check Lint results | ||
| env: | ||
| GOLANGCI_RESULT: ${{ needs.lint-mod.result }} | ||
| run: | | ||
| if [[ "${GOLANGCI_RESULT}" == "success" ]]; then | ||
| echo "All 'Lint' matrix jobs succeeded." | ||
| exit 0 | ||
| fi | ||
|
|
||
| if [[ "${GOLANGCI_RESULT}" == "cancelled" ]]; then | ||
| echo "'Lint' jobs were cancelled." | ||
| exit 1 | ||
| fi | ||
|
|
||
| if [[ "${GOLANGCI_RESULT}" == "failure" ]]; then | ||
| echo "'Lint' matrix jobs had failures." | ||
| exit 1 | ||
| fi | ||
|
|
||
| test: | ||
| name: Tests | ||
| if: ${{ always() }} | ||
| needs: test-mod |
Comment on lines
+12
to
+23
| strategy: | ||
| matrix: | ||
| modules: ['.','codec'] | ||
| name: Lint (${{ matrix.modules }}) | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Linting Go | ||
| uses: smartcontractkit/.github/actions/ci-lint-go@ci-lint-go/v4 | ||
| with: | ||
| golangci-lint-version: v2.4.0 | ||
| golangci-lint-version: v2.12.2 | ||
| golangci-lint-args: --timeout 5m | ||
| test: | ||
| name: Tests | ||
| test-mod: |
Comment on lines
+24
to
+42
| strategy: | ||
| matrix: | ||
| modules: ['.','codec'] | ||
| name: Tests (${{ matrix.modules }}) | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Install Aptos CLI | ||
| uses: aptos-labs/actions/install-aptos-cli@528ef7ad9427a8c0720ea3eea790a9190d6e377d # 2026-04-09 | ||
| with: | ||
| CLI_VERSION: 9.1.0 | ||
| - name: Build and test | ||
| uses: smartcontractkit/.github/actions/ci-test-go@ci-test-go/v1 | ||
| with: | ||
| use-go-cache: true | ||
|
|
||
| lint: | ||
| name: Lint | ||
| if: ${{ always() }} | ||
| needs: lint-mod |
product-security-plaid-production
Bot
requested review from
mmcallister-cll and
silaslenihan
Collaborator
Author
|
The 10 linter issues were pre-existing in code that was copied, and so can be ignored. The failure validates the matrix logic though 🙌 |
jmank88
requested review from
DylanTinianov,
LunkRat,
b-s-d,
johnnymugs,
krebernisak,
poopoothegorilla,
vlfig and
yashnevatia
JohnChangUK
approved these changes
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR creates a separate, top-level module
codec, which contains therelayer/codecandrelayer/chainreader/looppackages. This new module has ~100 less dependencies than the main module. The old packages are deprecated but remain compatible by forwarding to the new module.Supports:
TODO:
Split into two PRs to satisfy CI check for non-default branch commit hashescircle back to remove relative replaces