You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Let an agent tool's Permission Mode use a fixed selector or a variable such as <start.toolMode>. Resolve the active expression before tool filtering and reject invalid values before provider or tool work. Keep the fixed choice and expression separately, add the selector/variable toggle in the expanded tool controls, and support explicit mode selection through API/Copilot edits. Preserve the expression through workflow search and import/export. No feature flag.
Companion: simstudioai/mothership#488.
Type of Change
Bug fix
New feature
Breaking change
Documentation
Other: ___________
Testing
411 tests pass across nine focused suites, covering fixed/variable resolution, invalid values, secret tracking, API mode selection and unchanged round trips, import, and search. App and CLI type checks, changed-file lint, the API validation audit, and OpenAPI/CLI generated-artifact checks pass.
Existing limitations remain: API edits that reorder tools do not move their saved selector/variable modes with them, and editor reorders still save the tools and mode map separately. This change does not fix those behaviors. Earlier Chrome/CLI testing covered the feature; browser tests were not repeated for this revision.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Let an agent tool's Permission Mode use a fixed selector or a variable such as
<start.toolMode>. Resolve the active expression before tool filtering and reject invalid values before provider or tool work. Keep the fixed choice and expression separately, add the selector/variable toggle in the expanded tool controls, and support explicit mode selection through API/Copilot edits. Preserve the expression through workflow search and import/export. No feature flag.Companion: simstudioai/mothership#488.
Type of Change
Testing
411 tests pass across nine focused suites, covering fixed/variable resolution, invalid values, secret tracking, API mode selection and unchanged round trips, import, and search. App and CLI type checks, changed-file lint, the API validation audit, and OpenAPI/CLI generated-artifact checks pass.
Existing limitations remain: API edits that reorder tools do not move their saved selector/variable modes with them, and editor reorders still save the tools and mode map separately. This change does not fix those behaviors. Earlier Chrome/CLI testing covered the feature; browser tests were not repeated for this revision.
Checklist
Screenshots/Videos
No screenshots attached.