Conversation
Collaborator
|
Hi @agschrei thanks for the PR and the bug report ❤️ I prefer not to mix the monitoring list identification with the --group param in the same PR. I created #103 as a followup for the identification parameters. The API release deployed to prod next week will introduce a groups endpoint, which will be used in #102 LMK, if you find time to update your PR to tackle only #103. I'd also be interested in your input to refine the proposals in #103. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses #99 by adding two new options to the "monitoringlist import" click command:
idoption to allow referring to existing monitoring lists by IDgroupoption to allow declaring the organization group a monitoring list should be created inThe PR also adds unit tests that mock HTTP calls to verify the expected behavior.
I have tested my PR against
portal.vilocify.comand have found it to work as desired.