Skip to content

useVideoConfig().durationInFrames inside a Sequence is the Sequence's (#126) - #132

Merged
shinyobjectz merged 2 commits into
mainfrom
seq-duration
Nov 13, 2026
Merged

shinyobjectz merged 2 commits into
mainfrom
seq-duration

Conversation

@shinyobjectz

Copy link
Copy Markdown
Owner

Fixes #126. Supersedes #128: its spec line and conformance test are taken as written (commit d307694 is Ragulsundaram's), and the code is written from the spec alone, as #128 asked, since it was written after reading another library's implementation and raea's SDK is built from the spec and the conformance suite only.

bun test conformance: 615 pass, the same five failing as on main (hair, mesh2d alpha, routes, items, FC2a); the new test fails on main and passes here.

Ragulsundaram and others added 2 commits November 13, 2026 08:26
…uence's length (its own, cut short where its parent's ends; a Loop's children get one pass), as Remotion's public docs for useVideoConfig say, and its conformance test (#126, from #128)
…s length (#126): a subtree's LocalTime carries its length, the composition's at the root, a Sequence's own cut where its parent's ends (unbounded, what's left of its parent's), a Loop's one pass, and a Freeze keeps its parent's; useVideoConfig reports it as it reports a Sequence's width and height, and a Sequence's time is still the same object frame to frame. Written from the spec line and its conformance test (#128): conformance 615 pass, the same five failing as on main
@shinyobjectz
shinyobjectz merged commit e368a5d into main Nov 13, 2026
4 checks passed
@shinyobjectz
shinyobjectz deleted the seq-duration branch November 13, 2026 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

useVideoConfig().durationInFrames inside a <Sequence> is the composition's length; Remotion gives the Sequence's

2 participants