Repository navigation
Sequence: useVideoConfig().durationInFrames is the Sequence's length, as in Remotion (#126) - #128
Closed
Ragulsundaram wants to merge 1 commit into
Closed
Ragulsundaram wants to merge 1 commit into
Ragulsundaram wants to merge 1 commit into
Conversation
…hinyobjectz#126) Inside a Sequence, durationInFrames now reports the Sequence's own length, cut short where its parent's ends (unbounded: what's left of the parent's), as Remotion's docs describe; a Loop's children get one pass, a Freeze keeps its parent's. Spec line first (motion.feature), then LocalTime carries a duration that Sequence, Loop and Freeze set and useVideoConfig reads. Conformance: timeline.test.tsx covers own, unbounded, cut, nested, Loop and Freeze.
shinyobjectz
added a commit
that referenced
this pull request
Nov 13, 2026
…s length (#126): a subtree's LocalTime carries its length, the composition's at the root, a Sequence's own cut where its parent's ends (unbounded, what's left of its parent's), a Loop's one pass, and a Freeze keeps its parent's; useVideoConfig reports it as it reports a Sequence's width and height, and a Sequence's time is still the same object frame to frame. Written from the spec line and its conformance test (#128): conformance 615 pass, the same five failing as on main
Owner
|
Thank you, this was a real gap, and the repro made it easy to see. As you suggested, it's in via #132: your spec line and conformance test went in as written, under your name (e3dfcb9), and the code was written from the spec alone, because raea's SDK is built from the spec and the conformance suite only. Inside a Sequence, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #126.
Inside a
<Sequence>,useVideoConfig().durationInFramesnow gives the Sequence's length instead of the composition's, as Remotion's public docs foruseVideoConfigdescribe ("the end of the sequence in its local frame space"). Components that scale an animation to their scene, likeinterpolate(frame, [0, durationInFrames], ...), then run over the scene, as they do in Remotion.sdk/raea/spec/motion.feature("A composition is a component rendered once per frame") now says a Sequence reports its length: its owndurationInFrames, cut short where its parent's ends (unbounded means what's left of the parent's); a Loop's children get one pass; a Freeze keeps its parent's.LocalTimecarries aduration(the composition's at the root);Sequence,LoopandFreezeset it;useVideoConfigreads it as it already reads width and height. The kept-object checks include it, so a Sequence's time is still the same object frame to frame.sdk/raea/conformance/timeline.test.tsx"inside a Sequence, durationInFrames is the Sequence's" (own length, unbounded, cut by the composition's end, nested, Loop, Freeze). It fails without the change and passes with it. The rest ofbun test conformanceis unchanged (the same 5 failures as on main, in material, mesh2d, hair, items and routes), andtsc -p raea/tsconfig.check.jsonhas no new errors.On the clean-room process: before writing this I had looked at how Remotion computes the value to confirm the behaviour. The change follows the public docs and the spec text above, but if that matters for how raea is built, please treat this PR as a proposal and re-implement it from the spec line.