Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion VERSION
Original file line number Diff line number Diff line change
@@ -1 +1 @@
v1.1.4-dev
v1.1.5-dev
8 changes: 4 additions & 4 deletions internal/db/manager.go
Original file line number Diff line number Diff line change
Expand Up @@ -22,15 +22,15 @@ type Manager struct {
}

// NewManager creates a new database connection manager with separate writer and reader connections.
// If readerDSN is empty, the reader uses the same connection as the writer.
//
// sqlDriver is the registered sql driver name. Pass "" to use the default "mysql" driver.
// When OpenTelemetry tracing is enabled, pass the name returned by otelsql.Register() instead as
// When OpenTelemetry tracing is enabled, pass the name returned by otelsql.Register() instead
// that call wraps the "mysql" driver and returns a dynamically generated name that captures
// DB spans. Without this indirection, otelsql cannot intercept sql.Open.
//
// sqlDriver options:
// "" no tracing; NewManager defaults to "mysql"
// otelsql.Register("mysql") tracing enabled; dynamically registered driver wrapping "mysql"
// "" no tracing; NewManager defaults to "mysql"
// otelsql.Register("mysql") tracing enabled; dynamically registered driver wrapping "mysql"
func NewManager(sqlDriver, writerDSN, readerDSN string, logger *slog.Logger) (*Manager, error) {
if sqlDriver == "" {
sqlDriver = "mysql"
Expand Down
Loading