db: optional sql driver name for Manager, close on shutdown#11
Closed
sethgrid wants to merge 8 commits into
Closed
db: optional sql driver name for Manager, close on shutdown#11sethgrid wants to merge 8 commits into
sethgrid wants to merge 8 commits into
Conversation
- Extend db.NewManager with optional sqlDriver (empty defaults to mysql) - When tracing enabled, register otelsql and pass wrapped driver name - Server holds dbManager, tracerShutdown, and tracingEnabled; Close shuts down dbManager Made-with: Cursor
When HELLOWORLD_OTEL_EXPORTER_OTLP_ENDPOINT is set, install OTLP gRPC tracing, wrap the public Chi router with otelchi (route patterns as span names), and register otelsql so db.Manager uses the instrumented driver name. Add internal/tracing, server_config OTel env vars, logger trace_id/trace_sampled from span context, and span status/error recording in errorJSON and panic recovery. sqlDriver in NewManager is empty (mysql) without tracing and set to the otelsql registration when tracing is enabled. Close tracer and db manager on shutdown. Vendor OpenTelemetry, otelchi, otelsql, and dependencies. VERSION: v1.1.3-dev Made-with: Cursor
sethgrid
force-pushed
the
pr/3-db-manager-sql-driver
branch
from
23a5226 to
9567ef9
Compare
Owner
Author
|
Substance landed on main via PR4 (which was branched from this). Closing as superseded. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NewManager(sqlDriver, writerDSN, readerDSN, logger) uses sqlDriver for both pools; empty sqlDriver defaults to mysql. Server and taskqueue tests pass "".
Close db Manager during Server.Close alongside HTTP and task runner shutdown.
VERSION: v1.1.3-dev
Made-with: Cursor