Repository navigation
chore(governance): untrack generated fastio sidecar mirrors (ticket-252) - #310
Conversation
12543bb to
3cac088
Compare
There was a problem hiding this comment.
Validator approval after policy checks for exact head 3cac088d23b4258eefc5b6ad1d494ad08c41b479.
Ticket: ticket-252
Correlation ID: local-semcod-planfile-pr-310-ticket-252
Model: ollama/qwen3-coder:30b
Reviewed diff chunks: 5
Advisory LLM verdict: APPROVE
Advisory summary: Reviewed all 5 diff chunk(s). The governance.ownedPaths field in .governance/manifest.json should be updated to include the tracked .planfile/**/*.fast.json sidecar mirrors. The tracked .planfile/*.fast.json sidecar mirrors should be removed from the Git index while keeping *.fast.json ignored in .gitignore. | The PR removes the .planfile/*.fast.json sidecar mirrors and updates the .governance/manifest.json file to track only the governance.ownedPaths paths. | The commit introduces changes to governance and security practices, including updates to .governance/manifest.json and the removal of tracked .planfile/*.fast.json sidecar mirrors from the Git index. The commit also addresses a deployment failure by ensuring that the correct paths are assigned in the governance manifest and that the .planfile/*.fast.json files are ignored in the Git repository. | The pull request request has been approved. | The changes add .planfile/**/*.fast.json to the governance.ownedPaths in .governance/manifest.json, refresh the .governance/standard-adoption.json manifest digest, and untrack the three .planfile/**/*.fast.json files from Git. The governance-check.sh script verifies that the changes are correct, and the pytest tests ensure that the .planfile/**/*.fast.json files are removed and that the fastio tests pass.
Advisory findings: none
The LLM output above is advisory and was not used as the approval trust root.
Semantic review prerequisite: satisfied; policy 676cb4516bbfed2a000e40b9b1b6e4a430ecc761ec546aeb53d721a1905cfdd7.
Actual PR impact radar
Exact range: 4adc9a21c3ee03fd11fa4d83ecdccd8dde701147...3cac088d23b4258eefc5b6ad1d494ad08c41b479
Change digest: d1ac27223d82865f021ee0930785559d4f7d689fdb3dde0c02b6e95c0db1b027
Score: 48/100 (M), estimated 54 min, split recommended: true
Affected services/components: repository-wide/unclassified
Machine-readable radar JSONL and SVG
{"actual_change":{"additions":148,"base_sha":"4adc9a21c3ee03fd11fa4d83ecdccd8dde701147","binary_files":0,"categories":{"configuration":6,"docs":1},"change_digest":"d1ac27223d82865f021ee0930785559d4f7d689fdb3dde0c02b6e95c0db1b027","comparison":"4adc9a21c3ee03fd11fa4d83ecdccd8dde701147...3cac088d23b4258eefc5b6ad1d494ad08c41b479","deletions":42,"file_count":7,"files":["governance/manifest.json","governance/standard-adoption.json","planfile/config.yaml.fast.json","planfile/sprints/backlog.yaml.fast.json","planfile/sprints/current.yaml.fast.json","project/ticket-252/README.md","project/ticket-252/intent.json"],"head_sha":"3cac088d23b4258eefc5b6ad1d494ad08c41b479","service_count":0,"services":[]},"assessment_mode":"observed-pr","axes":{"coupling":3,"delivery":2,"scope":3,"uncertainty":3,"validation":1},"complexity":"M","confidence":0.9,"diagnostics":["RADAR-ACCEPTANCE-MISSING","RADAR-BUDGET-EXCEEDED"],"estimate":{"budget_minutes":30,"minutes":54,"within_budget":false},"impact":{"components":["governance","planfile","project"],"files":["governance/manifest.json","governance/standard-adoption.json","planfile/config.yaml.fast.json","planfile/sprints/backlog.yaml.fast.json","planfile/sprints/current.yaml.fast.json","project/ticket-252/README.md","project/ticket-252/intent.json"],"public_interfaces":[],"runtime_dependencies":0},"schema":"subactor.ticket-radar/v1","score":48,"split":{"parts":[{"estimated_minutes":15,"name":"Implement governance","scope":["governance"]},{"estimated_minutes":15,"name":"Implement planfile","scope":["planfile"]},{"estimated_minutes":15,"name":"Implement project","scope":["project"]},{"estimated_minutes":15,"name":"Validate and project to trackers","scope":["tests","planfile","github/gitlab/jira projections"]}],"reason":"estimated_minutes_exceed_budget","recommended":true},"standards":[{"id":"wellmanifest/dsl","revision":"6c60fc4e0dd1f1bb74f46a7745e28019908d1203","version":"0.1.0-dev"},{"id":"wellmanifest/ticket-lifecycle","revision":"5bf581907a87b46a13a73e6c033d3abe4d9a306f","version":"0.1.0-dev"},{"id":"wellmanifest/git-lifecycle","revision":"7d77d4b7af57e69bc75c3a0290b3a4805c5c4438","version":"0.2.0-dev"},{"id":"wellmanifest/logs","revision":"48c284ef7a069055c0bcb6b900147ce5e65f8b43","version":"0.3.0"}],"ticket_ref":"ticket-252"}<svg xmlns="http://www.w3.org/2000/svg" width="128" height="128" viewBox="0 0 128 128" role="img"><title>ticket-252: chore(governance): untrack generated fastio sidecar mirrors (ticket-252)</title><rect width="128" height="128" rx="12" fill="#f8fafc"/><g stroke-width="1"><polygon points="64,55 72,61 69,71 59,71 56,61" fill="none" stroke="#d7dde5"/><polygon points="64,47 80,59 74,78 54,78 48,59" fill="none" stroke="#d7dde5"/><polygon points="64,38 89,56 79,85 49,85 39,56" fill="none" stroke="#d7dde5"/><polygon points="64,30 97,53 84,92 44,92 31,53" fill="none" stroke="#d7dde5"/><polygon points="64,21 105,51 89,99 39,99 23,51" fill="none" stroke="#d7dde5"/><line x1="64" y1="64" x2="64" y2="21" stroke="#aab4c0"/><line x1="64" y1="64" x2="105" y2="51" stroke="#aab4c0"/><line x1="64" y1="64" x2="89" y2="99" stroke="#aab4c0"/><line x1="64" y1="64" x2="39" y2="99" stroke="#aab4c0"/><line x1="64" y1="64" x2="23" y2="51" stroke="#aab4c0"/></g><polygon points="64,38 89,56 79,85 59,71 48,59" fill="#fb923c" fill-opacity="0.45" stroke="#c2410c" stroke-width="2"/><circle cx="64" cy="64" r="3" fill="#c2410c"/><g font-family="sans-serif" font-size="7" fill="#334155"><text x="64" y="11" text-anchor="middle">SCO</text><text x="114" y="48" text-anchor="middle">COU</text><text x="95" y="107" text-anchor="middle">UNC</text><text x="33" y="107" text-anchor="middle">VAL</text><text x="14" y="48" text-anchor="middle">DEL</text></g><text x="64" y="124" text-anchor="middle" font-family="sans-serif" font-size="8" fill="#0f172a">M · 54m</text></svg>DECISION D-252-5889
TICKET ticket-252
HEAD_SHA 3cac088d23b4258eefc5b6ad1d494ad08c41b479
CORRELATION_ID local-semcod-planfile-pr-310-ticket-252
ACTOR agent:ifuri-validator-agent[bot]
APPLIED_RULE P-CORE-015
INPUT author_login = "tom-sapletta-com"
INPUT observed_checks = ["notify=PASS","ci-loop=PASS","governance / remote lifecycle=PASS","test (3.13)=PASS","test (3.10)=PASS","governance / enforce=PASS","freshness=PASS","onedev/local-verify=PASS"]
INPUT required_checks = ["ci-loop","notify","freshness","governance / remote lifecycle","governance / enforce","test (3.10)","test (3.13)","onedev/local-verify"]
INPUT required_checks_source = "protected registry + GitHub applied rules (env/request)"
INPUT reviewer_login = "ifuri-validator-agent[bot]"
INPUT semantic_review_assessment = {"schema":"subactor.validator/semantic-review-assessment/v1","subject":{"repository":"semcod/planfile","pull_request":310,"head_sha":"3cac088d23b4258eefc5b6ad1d494ad08c41b479","base_sha":"4adc9a21c3ee03fd11fa4d83ecdccd8dde701147","diff_sha256":"20af0f0c2272ec2120997859e04d692c4ac04dd2a245f1b7627b760987f81ae8"},"policy":{"policy_schema":"subactor.validator/semantic-review-policy/v1","policy_version":1,"policy_sha256":"676cb4516bbfed2a000e40b9b1b6e4a430ecc761ec546aeb53d721a1905cfdd7","required":true,"critical_paths":[".governance/manifest.json",".governance/standard-adoption.json"],"observed_paths":[".governance/manifest.json",".governance/standard-adoption.json",".planfile/config.yaml.fast.json",".planfile/sprints/backlog.yaml.fast.json",".planfile/sprints/current.yaml.fast.json","project/ticket-252/README.md","project/ticket-252/intent.json"]},"grounding":"full-diff-not-per-finding-proof","execution_authority":false,"status":"satisfied","reason":null,"review_sha256":"cec4025370a64326709e1dfd5b5b46e8b6b87952805fd42420c2dd9769d3877f","unresolved":[]}
INPUT superseded_checks = []
INPUT ticket_radar_receipt = {"schema":"subactor.ticket-radar/v1","base_sha":"4adc9a21c3ee03fd11fa4d83ecdccd8dde701147","head_sha":"3cac088d23b4258eefc5b6ad1d494ad08c41b479","change_digest":"d1ac27223d82865f021ee0930785559d4f7d689fdb3dde0c02b6e95c0db1b027","score":48,"complexity":"M","estimated_minutes":54,"split_recommended":true,"services":[],"authority":"ADVISORY","promotion":"FORBIDDEN"}
VERDICT APPROVE AUTHORITY DETERMINISTIC
REJECTED REQUEST_CHANGES BECAUSE NO_UNSAFE_CHANGE_REASON_FOUND
ADVISORY llm_verdict = "APPROVE" MODEL "ollama/qwen3-coder:30b"
ASSERT VERDICT_AUTHORITY != "ADVISORY"
Assign
.planfile/**/*.fast.jsontogovernance.ownedPathsin.governance/manifest.jsonand remove the tracked.planfile/*.fast.jsonsidecar mirrors from the Git index while keeping*.fast.jsonignored in.gitignore.Closes #272