Fix missed imports and comment-based crypto findings - #15
Merged
Conversation
This was referenced Sep 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An OpenSSL include following a copyright comment was skipped by the whole-file hint, while a commented-out
EVP_aes_256_gcm()produced an AES-GCM finding.Compile conservative include hints by removing zero-width regex assertions from regex-syntax's parsed representation. The original regexes still decide whether AST import nodes anchor a library. This covers
^,$,\A,\z, and nested assertions without string-based regex rewriting, while continuing to reject files with no relevant text.Mask Tree-sitter comment spans before API fallback, algorithm matching, and constant collection. Preserve byte offsets, line endings, and string contents so evidence remains accurate. Both standalone comments and comments nested inside call nodes are covered. This does not add data-flow analysis or suppress ordinary strings/docstrings.
Validation: seven focused regression tests, all existing ground-truth fixtures, library and minimal-feature tests, formatting, and all-target Clippy with warnings denied under all and minimal features.
patterns.tomland all fixtures remain unchanged.regex-syntaxwas already present transitively and is now a direct dependency.Part 2 of the review series; independent of #14 and based on
main.