Fix uppercase source discovery and parse TSX with its own grammar - #17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Directory scans silently skipped uppercase source extensions even though
language_from_pathaccepted them..tsxfiles were parsed as ordinary TypeScript, producing syntax errors around JSX.Use the extension resolver as the single discovery filter, select the dedicated TSX grammar via
Language::Tsx, and share TypeScript patterns/constants between both grammars. Preserve ordinary TypeScript angle-bracket assertions and the conventional distinction between.cand.C. Run OpenSSL C fixtures in C-only builds; those tests were incorrectly gated on both C and C++.Validation: extension, directory-discovery, TSX parse-tree, CLI, and TypeScript regression tests; existing fixture suites; all/minimal/C-only/TypeScript-only tests; all-target Clippy with warnings denied under all and minimal features; formatting; Rust 1.88 all-target/all-feature compilation. All pattern and fixture files are unchanged.
Part 4 of the review series, independently based on
main. Related: #14, #15, #16. Library clients with exhaustive matches onLanguagewill need to handle the newTsxvariant.