Repository navigation
fix(browser-recording): a frame waits out a page that's busy or between documents - #643
Merged
earakely-scale merged 2 commits intoNov 12, 2026
Merged
Conversation
…en documents On a heavy site (Online-Mind2Web's Target task), both arms lost 3 frames each while pages loaded: - "Page.captureScreenshot: Not attached to an active page", while a navigation swaps the tab's document - "the tab painted nothing within 3 s", a page too busy to paint Each missing frame failed its run as an infrastructure failure. A frame now has FRAME_CAPTURE_S (10 s) to show, rather than a screenshot's 3 s, since it's taken in the background. A capture refused between documents is asked again every 0.25 s within that budget. Any other refusal, or a frame still not shown after it, is missing as before. The extension now names how long a start and an end may take (START_S, END_S), and the steps wait that long, not the 30 s default an end's last two frames could now outlast. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…wait on, and recheck a dialog after a retry - START_S and END_S count every upload a start or an end waits on (a frame in flight, the last two frames, the log and the manifest) at the transfer helpers' own stall budget, plus a reply's margin, instead of a made-up 30 s. Teardown's end_all for a browser waits as long. - A frame retried after its tab closed meanwhile rechecks the replacement tab's dialog, so a tab a dialog holds gives the frame it last took instead of a capture that can't paint. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
earakely-scale
deleted the
edgararakelyan/browser-frames-survive-busy-pages
branch
November 12, 2026 21:09
3 of 4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A follow-up to #633 (M8.23, FD-4971): a frame now waits out a page that's too busy to paint, or between documents mid-navigation, instead of going missing.
Online-Mind2Web's first sample eval lost frames on its Target task. Both arms lost 3 each while target.com's pages loaded, and each missing frame failed its run as an infrastructure failure, as it should. The captures failed in two ways:
Page.captureScreenshot: Not attached to an active page: a navigation was swapping the tab's document, so for a moment there was nothing to capture.the tab painted nothing within 3 s: the page was too busy to paint in time. feat(browser): browser-recording/v1 with frames after each agent action, keyed to the action log (FD-4971) #633's second capture doesn't help with this one.At 300 tasks, many on heavy sites, this would fail a lot of runs.
What changes
BrowserControl.frame(website_browser/control.py)FRAME_CAPTURE_S, 10 s, to show, rather than a screenshot's 3 s. A frame is taken in the background, after a burst of actions settles, so nothing waits on it the way an agent waits on a screenshot.BETWEEN_DOCUMENTS) is asked again every 0.25 s within that budget. It's asked of the active tab if the tab closed meanwhile.How long a recording's calls take (
website_browser/recording.py,task_steps/browser/recording.py)START_S). It also names how long an end takes (END_S): a frame still in flight, its last two frames, the wait for its log, and the log's and the manifest's uploads.TRANSFER_STALL_BUDGET_SECONDS, the longest they take to give up on an upload whose connections all stall. That makes the bounds 318 s and 1,450 s at worst; a normal end answers in seconds.start_browser_recordingandend_browser_recordingwait that long. Before, they used the 30 s default, which an end's last two frames could now outlast. Teardown'send_allfor a browser waits as long too.Test plan
test_browser_recording.py):browser_recording_test.py): the start and end calls waitSTART_SandEND_S.tst/unit/task_step,providersandtask: 6,542 passed, 8 skipped.tools, 3 of 28 oncdp.toolssuccess,cdpfailure (it didn't apply the job-category filter).Docs
The user guide's browser recording section should say that a frame waits up to 10 s for a page that's loading or busy, and how long a start and an end take.
🤖 Generated with Claude Code


Confidence Score: 5/5
The PR appears safe to merge.Summary
Browser recordings give busy pages more time to paint and retry captures refused during navigation.
Reviews (6) · Last reviewed commit: "fix(browser-recording): bound a start an..." · Reviewed by Greptile