Repository navigation
fix(browser-recording): a recording ends complete when an action is still going, or a tab's session went away - #650
Merged
earakely-scale merged 2 commits intoNov 12, 2026
Conversation
…till going, or a tab's session went away Online-Mind2Web's agreement runs lost two runs to the recording's end: - An action still going when a run ended held back every later log line. The log stands one in as unfinished only after STALLED_S (60 s), and an end waits LOG_WAIT_S (10 s), so that run's log was missing 357 entries. Now, once its wait is up, an end writes the actions still going up to its last entry as unfinished (BrowserLog.read(settle_through=...)). The log then holds every line to the end, an action in flight marked as such. - A frame refused with "Session with given id not found", its tab detached or attached anew, was missing at once. It's now asked again within the frame budget, on the session the tab has then, else the active tab's. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ached anew A frame retried after its session went away looked once for the tab's new session, else the active tab's. With the only tab detached and its new session not there yet, that raised "no tab open" with most of the frame's budget left. It now waits for a session within the budget. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
earakely-scale
deleted the
edgararakelyan/browser-recording-ends-complete
branch
November 12, 2026 22:16
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A follow-up to #643: a browser recording now ends complete when an agent's action is still going at the end, and a frame survives its tab's session going away.
The first batch of Online-Mind2Web's agreement runs (M8.48) lost 2 of 10 runs as infrastructure failures, both at the recording's end:
STALLED_S(60 s), but an end waits onlyLOG_WAIT_S(10 s) for its lines, so everything after that action was withheld.Page.captureScreenshot: Session with given id not found. The tab's session went away between choosing the tab and capturing it. fix(browser-recording): a frame waits out a page that's busy or between documents #643 retried only refusals between documents, so this frame was missing at once.What changes
BrowserLog.read(..., settle_through=n)writes each action begun at or before entrynand still going as unfinished now, as a stalled one is afterSTALLED_S. Its outcome still gets a line of its own once it ends.LOG_WAIT_Sfor its lines, as before. Then it reads once more, settling through its last entry. Its log holds every line from its start to its end, with an action still in flight markedunfinished. A line reserved and never written, such as a tab event, is stilllog_missing, and the run still fails.FOR_THE_MOMENT, which replacesBETWEEN_DOCUMENTS). It's asked on the session the tab has by then, else the active tab's. While there's no tab at all, as when the only one is between sessions, it waits for one within the budget.Test plan
test_browser_log.py): a read settling through an entry writes the actions still going up to it as unfinished, and leaves a later one pending until it ends.test_browser_recording.py):tst/unit/task_stepandtst/unit/drivers, 4,346 passed.Docs
The user guide's browser recording section should say that an action still in flight at a recording's end is in its log, marked
unfinished.🤖 Generated with Claude Code


Confidence Score: 5/5
The PR appears safe to merge; the session retry fix addresses the previous finding.Summary
Browser recordings now keep in-flight actions as
unfinishedand retry captures after a tab loses its session.Reviews (4) · Last reviewed commit: "fix(browser-recording): a frame waits wi..." · Reviewed by Greptile