Skip to content

I686-msvc: drop host tools#159032

Open
Fulgen301 wants to merge 2 commits into
rust-lang:mainfrom
Fulgen301:i686-try-drop-host-tools
Open

I686-msvc: drop host tools#159032
Fulgen301 wants to merge 2 commits into
rust-lang:mainfrom
Fulgen301:i686-try-drop-host-tools

Conversation

@Fulgen301

@Fulgen301 Fulgen301 commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@rustbot

rustbot commented Jul 9, 2026

Copy link
Copy Markdown
Collaborator

Warning

If you are changing how CI LLVM is built or linked, make sure to bump
src/bootstrap/download-ci-llvm-stamp.

cc @jieyouxu

@rustbot rustbot added A-CI Area: Our Github Actions CI A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Jul 9, 2026
@rustbot rustbot added the T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. label Jul 9, 2026
@rustbot

rustbot commented Jul 9, 2026

Copy link
Copy Markdown
Collaborator

r? @jdno

rustbot has assigned @jdno.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: infra-ci
  • infra-ci expanded to Kobzol, Mark-Simulacrum, jdno, jieyouxu, marcoieni
  • Random selection from Mark-Simulacrum, jdno, jieyouxu, marcoieni

@mati865

mati865 commented Jul 9, 2026

Copy link
Copy Markdown
Member

@bors delegate try

@rust-bors

rust-bors Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

✌️ @Fulgen301, you can now perform try builds on this pull request!

You can now post @bors try to start a try build.

@mati865

mati865 commented Jul 9, 2026

Copy link
Copy Markdown
Member

@bors delegate try

@rust-bors

rust-bors Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

✌️ @Fulgen301, you can now perform try builds on this pull request!

You can now post @bors try to start a try build.

@mati865 mati865 unassigned jdno Jul 9, 2026
@mati865 mati865 added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 9, 2026
@Fulgen301

Fulgen301 commented Jul 9, 2026

Copy link
Copy Markdown
Contributor Author

@bors try jobs=i686-msvc

@rust-bors

This comment has been minimized.

Sign in to view
rust-bors Bot pushed a commit that referenced this pull request Jul 9, 2026
@bors
Auto merge of #159032 - Fulgen301:i686-try-drop-host-tools, r=<try>
7b9aa79 
I686-msvc: drop host tools


try-job: i686-msvc
@rust-bors

rust-bors Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

💔 Test for 7b9aa79 failed: CI. Failed job:

@rust-log-analyzer

rust-log-analyzer commented Jul 9, 2026

Copy link
Copy Markdown
Collaborator

A job failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot) 
   Compiling ureq v3.0.8
   Compiling citool v0.1.0 (/home/runner/work/rust/rust/src/ci/citool)
    Finished `dev` profile [unoptimized] target(s) in 22.19s
     Running `target/debug/citool calculate-job-matrix`
Run type: TryJob { job_patterns: Some(["i686-msvc"]) }
Error: Failed to calculate job matrix

Caused by:
    Patterns `i686-msvc` did not match any auto jobs
##[error]Process completed with exit code 1.
Post job cleanup.

@ChrisDenton

ChrisDenton commented Jul 9, 2026

Copy link
Copy Markdown
Member

you need to do i686-msvc* (it's a kind of glob)

@Fulgen301

Fulgen301 commented Jul 9, 2026

Copy link
Copy Markdown
Contributor Author

Oh, thanks.

@bors try jobs=i686-msvc*

@rust-bors

This comment has been minimized.

Sign in to view
rust-bors Bot pushed a commit that referenced this pull request Jul 9, 2026
@bors
Auto merge of #159032 - Fulgen301:i686-try-drop-host-tools, r=<try>
22be136 
I686-msvc: drop host tools


try-job: i686-msvc*
@rust-bors

rust-bors Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

☀️ Try build successful (CI)
Build commit: 22be136 (22be136f9995f34607c5c3210da87a400a30e092)
Base parent: 3664b37 (3664b37017c529cad0f0ed259769f15743c21a6a)

@rust-bors

rust-bors Bot commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

Unknown command "try". Run @bors help or go to https://bors.rust-lang.org/help to see available commands.

@workingjubilee

workingjubilee commented Jul 10, 2026

Copy link
Copy Markdown
Member

@bors try jobs=dist-i686-msvc

@rust-bors

This comment has been minimized.

Sign in to view
rust-bors Bot pushed a commit that referenced this pull request Jul 10, 2026
@bors
Auto merge of #159032 - Fulgen301:i686-try-drop-host-tools, r=<try>
80f53fe 
I686-msvc: drop host tools


try-job: dist-i686-msvc
@Fulgen301 Fulgen301 mentioned this pull request Jul 10, 2026
Merged
@rust-bors

rust-bors Bot commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

☀️ Try build successful (CI)
Build commit: 80f53fe (80f53fe88b0c23006d1c3cf74317e35091dccd3a)
Base parent: 3ead112 (3ead112e67f8feb4d6b09e12f1b5d83b87698961)

JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Jul 11, 2026
@JonathanBrouwer
Rollup merge of rust-lang#159060 - Fulgen301:bootstrap-cdb-discovery-…
7f020fd 
…target, r=jieyouxu

Look for the cdb architecture that corresponds to the target triple

instead of the build triple

Debugging other architectures with the build target CDB is neither a common nor a good user experience - for example, when targeting i686 from a x86_64 build target, you get all the internal WOW64 events, which also break debuginfo tests. (See rust-lang#159032)

Use the cdb.exe that corresponds to the target's architecture instead.
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Jul 11, 2026
@JonathanBrouwer
Rollup merge of rust-lang#159060 - Fulgen301:bootstrap-cdb-discovery-…
d596cdf 
…target, r=jieyouxu

Look for the cdb architecture that corresponds to the target triple

instead of the build triple

Debugging other architectures with the build target CDB is neither a common nor a good user experience - for example, when targeting i686 from a x86_64 build target, you get all the internal WOW64 events, which also break debuginfo tests. (See rust-lang#159032)

Use the cdb.exe that corresponds to the target's architecture instead.
@rust-bors

rust-bors Bot commented Jul 11, 2026

Copy link
Copy Markdown
Contributor

☔ The latest upstream changes (presumably #159142) made this pull request unmergeable. Please resolve the merge conflicts by rebasing.

rust-timer added a commit that referenced this pull request Jul 11, 2026
@rust-timer
Unrolled build for #159060
61d13e5 
Rollup merge of #159060 - Fulgen301:bootstrap-cdb-discovery-target, r=jieyouxu

Look for the cdb architecture that corresponds to the target triple

instead of the build triple

Debugging other architectures with the build target CDB is neither a common nor a good user experience - for example, when targeting i686 from a x86_64 build target, you get all the internal WOW64 events, which also break debuginfo tests. (See #159032)

Use the cdb.exe that corresponds to the target's architecture instead.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

A-CI Area: Our Github Actions CI A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@Fulgen301 @rustbot @mati865 @rust-log-analyzer @ChrisDenton @workingjubilee @jdno