Skip to content

Look for the cdb architecture that corresponds to the target triple#159060

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
Fulgen301:bootstrap-cdb-discovery-target
Jul 11, 2026
Merged

Look for the cdb architecture that corresponds to the target triple#159060
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
Fulgen301:bootstrap-cdb-discovery-target

Conversation

@Fulgen301

@Fulgen301 Fulgen301 commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

instead of the build triple

Debugging other architectures with the build target CDB is neither a common nor a good user experience - for example, when targeting i686 from a x86_64 build target, you get all the internal WOW64 events, which also break debuginfo tests. (See #159032)

Use the cdb.exe that corresponds to the target's architecture instead.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Jul 10, 2026
@rustbot

rustbot commented Jul 10, 2026

Copy link
Copy Markdown
Collaborator

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: bootstrap
  • bootstrap expanded to 6 candidates
  • Random selection from Mark-Simulacrum, clubby789, jieyouxu

@rust-log-analyzer

This comment has been minimized.

instead of the build triple

Debugging other architectures with the build target CDB is neither a common
nor a good user experience - for example, when targeting i686 from a x86_64
build target, you get all the internal WOW64 events, which also break
debuginfo tests.

Use the cdb.exe that corresponds to the target's architecture instead.
@Fulgen301 Fulgen301 force-pushed the bootstrap-cdb-discovery-target branch from 17524d2 to 83f5101 Compare July 10, 2026 09:45
@jieyouxu jieyouxu self-assigned this Jul 11, 2026

@jieyouxu jieyouxu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, yeah, this definitely makes more sense

View changes since this review

@jieyouxu

Copy link
Copy Markdown
Member

@bors r+ rollup

@rust-bors

rust-bors Bot commented Jul 11, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 83f5101 has been approved by jieyouxu

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 11, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Jul 11, 2026
…target, r=jieyouxu

Look for the cdb architecture that corresponds to the target triple

instead of the build triple

Debugging other architectures with the build target CDB is neither a common nor a good user experience - for example, when targeting i686 from a x86_64 build target, you get all the internal WOW64 events, which also break debuginfo tests. (See rust-lang#159032)

Use the cdb.exe that corresponds to the target's architecture instead.
rust-bors Bot pushed a commit that referenced this pull request Jul 11, 2026
…uwer

Rollup of 8 pull requests

Successful merges:

 - #159126 (Fix PR number in bootstrap's change tracker)
 - #156968 (diagnostics: suggest generic_const_args for const ops)
 - #159012 (Shrink mir::Statement to 40 bytes)
 - #158182 (std: use `OnceLock` for SGX argument storage)
 - #159114 (Add regression test for $-prefixed fragment specifier in repetition)
 - #159060 (Look for the cdb architecture that corresponds to the target triple)
 - #159089 (riscv: update c-variadic test for LLVM changes)
 - #159093 (pretty-print: use inline asm's actual macro name)
rust-bors Bot pushed a commit that referenced this pull request Jul 11, 2026
…uwer

Rollup of 8 pull requests

Successful merges:

 - #159126 (Fix PR number in bootstrap's change tracker)
 - #156968 (diagnostics: suggest generic_const_args for const ops)
 - #159012 (Shrink mir::Statement to 40 bytes)
 - #158182 (std: use `OnceLock` for SGX argument storage)
 - #159114 (Add regression test for $-prefixed fragment specifier in repetition)
 - #159060 (Look for the cdb architecture that corresponds to the target triple)
 - #159089 (riscv: update c-variadic test for LLVM changes)
 - #159093 (pretty-print: use inline asm's actual macro name)
rust-bors Bot pushed a commit that referenced this pull request Jul 11, 2026
…uwer

Rollup of 14 pull requests

Successful merges:

 - #159126 (Fix PR number in bootstrap's change tracker)
 - #155811 (Include AtomicU128/AtomicI128 in docs for any target)
 - #156968 (diagnostics: suggest generic_const_args for const ops)
 - #159012 (Shrink mir::Statement to 40 bytes)
 - #156618 (rustdoc: test ignoring rustc lints in CLI)
 - #158182 (std: use `OnceLock` for SGX argument storage)
 - #159114 (Add regression test for $-prefixed fragment specifier in repetition)
 - #158523 (Fix feature gate for `repr(simd)`)
 - #158876 (Fix multiple logic bugs in `Arc::make_mut`)
 - #158928 (std: fix Xous UDP send_to length mismatch and truncation)
 - #159060 (Look for the cdb architecture that corresponds to the target triple)
 - #159089 (riscv: update c-variadic test for LLVM changes)
 - #159093 (pretty-print: use inline asm's actual macro name)
 - #159122 (doc: use ptr::addr in offset_from docs)

Failed merges:

 - #158732 (Apply MCP 1003 and move diagnostics.rs into its own module)
@rust-bors rust-bors Bot merged commit d596cdf into rust-lang:main Jul 11, 2026
13 checks passed
@rustbot rustbot added this to the 1.99.0 milestone Jul 11, 2026
rust-timer added a commit that referenced this pull request Jul 11, 2026
Rollup merge of #159060 - Fulgen301:bootstrap-cdb-discovery-target, r=jieyouxu

Look for the cdb architecture that corresponds to the target triple

instead of the build triple

Debugging other architectures with the build target CDB is neither a common nor a good user experience - for example, when targeting i686 from a x86_64 build target, you get all the internal WOW64 events, which also break debuginfo tests. (See #159032)

Use the cdb.exe that corresponds to the target's architecture instead.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants