Conversation
|
This draft does not yet fully build with edition 2024 marked on all crates. |
The lifetime change is due to a lint error from clippy that did not find this problem in prior versions. The change itself shouldn't effect code depending on the cortex-m crate.
wt
force-pushed
the
update_msrv
branch
15 times, most recently
from
6092f57 to
b7bfb5b
Compare
wt
force-pushed
the
update_msrv
branch
4 times, most recently
from
b7bfb5b to
14b926e
Compare
I also explicitly set the rustfmt style to 2021 to prevent formatting churn in this same commit.
Needed to update the assembled libs because the formatting touched the asm boilerplate.
|
I think we should update the asm toolchain to the latest stable. Is there any reason not to do that? |
|
I'd actually like to drop the asm blobs. I cannot believe anyone is seriously relying on them in this day and age. |
Agreed, as longs as the inline-asm feature in cargo remains, it shouldn't be a breaking change. So remove the blobs, and remove all cfgs using inline-asm. But strictly speaking that could or maybe even should be a different PR |
|
We previously removed the blobs in the old (breaking-changes v0.8) master branch, which was reverted in #605, and the idea was to backport that removal (as it needn't be a breaking change). Most of the backports happened in #606, but a few aren't done yet, including #423 and #432 for inline asm. I'm on board with getting those two backported to the new (non-breaking v0.7) branch before we cut a new 0.7 release, but I won't have time to look at myself it for a few weeks. |
|
Thanks for doing this, all LGTM! |
|
I'm happy to pitch in more where I can. |
4 participants
Closes #626