Conversation
wt
force-pushed
the
update_asm_toolchain
branch
4 times, most recently
from
0fe3a7c to
2abb7dd
Compare
wt
force-pushed
the
update_asm_toolchain
branch
4 times, most recently
from
ec6c7ef to
667de8f
Compare
wt
force-pushed
the
update_asm_toolchain
branch
8 times, most recently
from
b9cb8b5 to
74e91d2
Compare
The `cm7-r0p1` feature only works with the plateform feature `armv7em`. I added a compile error to help someone figure that out more redily if they accidentally combine those features.
This will allow getting all the asm in shape for edition 2024.
wt
force-pushed
the
update_asm_toolchain
branch
8 times, most recently
from
9cad22a to
256dc0f
Compare
wt
force-pushed
the
update_asm_toolchain
branch
16 times, most recently
from
3a0b6e9 to
0d75936
Compare
|
@thejpster Here's what you asked for. |
Inline asm has been supported in stable rust for some time, so I removed the separate asm build infra and added that code to the normal crate code. I also crated a mock of the asm functions that were needed to run clippy with a non-arm target (like x86_64).
wt
force-pushed
the
update_asm_toolchain
branch
from
0d75936 to
e7d07d2
Compare
.github/workflows/clippy.yml
Outdated
| strategy: | ||
| matrix: | ||
| # All generated code should be running on stable now | ||
| rust: [stable] |
There was a problem hiding this comment.
clippy should only be run on a fixed version, otherwise new releases that add new lints will break the build.
.github/workflows/clippy.yml
Outdated
|
|
||
| # steps: | ||
| # - uses: actions/checkout@v4 | ||
| # - uses: dtolnay/rust-toolchain@1.85 |
There was a problem hiding this comment.
Can the commented out text be removed?
|
Had a quick look on my phone - looks ok, just a few notes. I want to inspect the symbol table later when I get to a laptop. |
wt
force-pushed
the
update_asm_toolchain
branch
from
e7d07d2 to
29ef316
Compare
|
I removed the change to the clippy runs since I added the mock so that it can be run without issue with clippy targeting x86. |
|
If you want me to add that change to the tests back in for clippy I can. It was not really related to this change, so I didn't want to add more complexity. |
| #[cfg_attr(any(armv6m, armv7m, armv7em, armv8m), path = "asm/inner.rs")] | ||
| #[cfg_attr( | ||
| all(not(armv6m), not(armv7m), not(armv7em), not(armv8m)), | ||
| path = "asm/inner_mock.rs" | ||
| )] |
There was a problem hiding this comment.
If I understand this correctly this changes the behavior from declaring an extern "C" unsafe fn for the asm functions (which is what call_asm! does if inline-asm is not enabled) to silently replacing all functions with nops if the target is not one of these.
Before this PR, it would be a compile time error if one of these functions is used on an unsupported target (I think).
Is this the intended new behavior?
3 participants
This is a draft for updating the asm toolchain. It's based on my #628, so it shouldn't be landed before that is.