Skip to content

Fix a couple of CI failues #597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tcharding merged 2 commits into from
May 21, 2026
+3 −3
Merged

Fix a couple of CI failues #597

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5ad61fc
Fix control-char property test
jamillambert May 20, 2026
4127c8b
Gate webpki_roots import on webpki-roots
jamillambert May 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions bitreq/src/connection/rustls_stream.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ use rustls::{self, ClientConfig, ClientConnection, RootCertStore, StreamOwned};
use tokio_native_tls::TlsConnector as AsyncTlsConnector;
#[cfg(any(feature = "async-https-rustls", feature = "async-https-rustls-probe"))]
use tokio_rustls::{client::TlsStream, TlsConnector};
#[cfg(feature = "rustls-webpki")]
#[cfg(feature = "webpki-roots")]
use webpki_roots::TLS_SERVER_ROOTS;

#[cfg(any(feature = "async-https-rustls", feature = "async-https-rustls-probe"))]
Expand All @@ -41,7 +41,7 @@ fn build_client_config() -> Arc<ClientConfig> {
let _ = root_certificates.add(cert);
}

#[cfg(feature = "rustls-webpki")]
#[cfg(feature = "webpki-roots")]
root_certificates.extend(TLS_SERVER_ROOTS.iter().cloned());

let config =
Expand Down
2 changes: 1 addition & 1 deletion bitreq/tests/url_properties.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -333,7 +333,7 @@ proptest! {
ctrl_char in 0u8..32u8,
suffix in "[a-z]{0,10}"
) {
if ctrl_char.is_ascii_whitespace() && suffix.is_empty() {
if char::from(ctrl_char).is_whitespace() && suffix.is_empty() {
return Ok(());
}
let invalid_url = format!("{}{}{}", prefix, ctrl_char as char, suffix);
Expand Down
Loading