Fix a couple of CI failues#597
Merged
Merged
Conversation
The control character proptest assumed only ASCII whitespace could be trimmed from the end of the input. Url::parse uses str::trim(), which follows Rust's Unicode whitespace rules, so trailing vertical tab was accepted after trimming and the test failed. Fix the test to skip trailing control characters using char::is_whitespace() instead of is_ascii_whitespace(), so the property matches the parser's actual behavior.
jamillambert
requested review from
TheBlueMatt,
oleonardolima and
tnull
as code owners
satsfy
approved these changes
May 20, 2026
Contributor
There was a problem hiding this comment.
tACK 86b2260
Thanks for fixing! I run into this error frequently. Tried fixing it some months ago, but in the wrong context #540 (comment)
Petty nit: on commit 86b226 webpki-root missing an s and it says tetst .
rustls_stream.rs imported and used webpki_roots::TLS_SERVER_ROOTS behind the rustls-webpki feature. Enabling rustls-webpki in the CI test without webpki-roots causes a failure. Gate the import on webpki-roots, which is the feature that enables that crate.
jamillambert
force-pushed
the
0520-CI-fixes
branch
from
86b2260 to
4127c8b
Compare
Collaborator
Author
|
Fixed the commit log. |
tcharding
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that CI uses rbmt, random combinations of features are tested in CI. This causes CI failures on PRs unrelated to the PR changes, often due to feature gates.
Fix two that came up recently.