Skip to content

feat: changing codepage #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fdevans merged 3 commits into from
Aug 3, 2026
Merged

feat: changing codepage #104

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7624745
feat: chainging codepage
yamamoto-taizo Feb 18, 2024
db5ab41
Validate RD_NODE_CODEPAGE and make default codepage a module constant
fdevans Aug 3, 2026
1f8d187
Merge branch 'main' into issues/103
fdevans Aug 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion contents/winrm_session.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@
PY34 = sys.version_info[0:2] >= (3, 4)
RD = "RD_"
INVALID_CHAR = "%"
DEFAULT_CODEPAGE = 65001

if PY3:
string_types = str,
Expand Down Expand Up @@ -70,9 +71,17 @@ def run_cmd(self, command, args=(), out_stream=None, err_stream=None, retry=1, r

shell_id = None

codepage = DEFAULT_CODEPAGE
if "RD_NODE_CODEPAGE" in os.environ:
try:
codepage = int(os.getenv("RD_NODE_CODEPAGE").strip())
except ValueError:
log.warning("Invalid RD_NODE_CODEPAGE value, falling back to default codepage " + str(DEFAULT_CODEPAGE))
codepage = DEFAULT_CODEPAGE

while retryCount < retry:
try:
shell_id = self.protocol.open_shell(codepage=65001, env_vars=envs)
shell_id = self.protocol.open_shell(codepage=codepage, env_vars=envs)
break
except ConnectionError as e:
if retryCount < retry:
Expand Down
Loading